Rockbox

Tasklist

FS#507 - disable scroll while filling mpeg buffer

Attached to Project: Rockbox
Opened by Philipp Pertermann (langhaarrocker) - Sunday, 03 November 2002, 23:36 GMT
Last edited by Philipp Pertermann (langhaarrocker) - Thursday, 09 January 2003, 10:38 GMT
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

We had a serious performance problem with playback of
bitrates > 256 kBit/s. This was because scrolling
multiple lines (especially in combination with the peak
meter) ate to much performance.
This patch disables scrolling while the mpeg buffer is
being filled. I had no problems with bitrates of 320 kBit/s
and the peak meter in high performance mode and 5
lines scrolling. (well, not scrolling while filling the buffer,
of course!)

I also enabled the double reading in the peak meter
again because that improves the clip detection
enormously.

Phil
This task depends upon

Closed by  Philipp Pertermann (langhaarrocker)
Thursday, 09 January 2003, 10:38 GMT
Reason for closing:  Rejected
Additional comments about closing:  Logged In: YES
user_id=637126

The bug is fixed and was neither a scroll nor a peak meter
problem.
But still I'd consider peak meter info as a higher priority than
scrolling since it is a real-time information. When you e.g.
record from the jb to tape you will want to know the peaks for
level settings. Interrupting the meter means that you can
miss peaks and overdrive your recorder without notice. In this
situation scrolling without interruption is nice to have - but not
necessary. An interrupted peak meter degrades it into a
useless gimmick.
Luckily this problem was solved somewhere else.

Phil
Comment by Björn Stenberg (zagor) - Thursday, 09 January 2003, 01:10 GMT

This is not a scroll issue, and thus the scroll should not be
affected. If anything, the peak meter should be disabled.
Comment by Philipp Pertermann (langhaarrocker) - Thursday, 09 January 2003, 10:38 GMT

The bug is fixed and was neither a scroll nor a peak meter
problem.
But still I'd consider peak meter info as a higher priority than
scrolling since it is a real-time information. When you e.g.
record from the jb to tape you will want to know the peaks for
level settings. Interrupting the meter means that you can
miss peaks and overdrive your recorder without notice. In this
situation scrolling without interruption is nice to have - but not
necessary. An interrupted peak meter degrades it into a
useless gimmick.
Luckily this problem was solved somewhere else.

Phil

Loading...