Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by punkrockguy318 - 2006-04-16

FS#5139 - Jewels: Pause on hold patch

It is cumbersome to have to press pause, and then press hold when you want to take a quick break from playing a game. In this patch, the pause menu will be brough up when the hold button is pressed. Before button input is taken, a quick check to see if the hold button is on happens.

The one change I made to existing code was the button input. I changed it from button_get to button_get_w_tmo. Without this change, the check for hold would never work.

Closed by  midkay
2006-04-16 05:29
Reason for closing:  Invalid
Additional comments about closing:  

Useless! ;)

What is the purpose of this patch? There is no “pause” in Jewels and there is no need for “pause” functionality. Since button_get(true) blocks, nothing is running in Jewels currently if no keys are pressed. Am I missing something?

Your actually quite right. It’s about 11:40 where I am right now, and I made that patch without even thinking about this. Don’t use this patch. However, i did use this concept in a few other plugin applications which are actually useful (snake, snake2, and brickmania). Sorry about that…

I should add that in addition, this patch makes Jewels much less efficient and wastes power because it causes the screen to be redrawn 4 times per second even when there are no changes to draw the screen. Also the hold functionality already works fine the way it is; if you turn on hold, Jewels isn’t run because it’s blocking on the button_get(true) and no key presses are registered while hold remains held.

Ah, no problem ;)

Is there any way I can close/reject this?
By the way, while your at it I would suggest you take a look at
http://www.rockbox.org/tracker/task/5140 through 5143.
Those patches are for the same idea, but for applications that can actually make good use of it (ie: button_get(false) applications :) )

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing