Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category LCD
  • Assigned To No-one
  • Operating System iPod 5G
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes 5
  • Private
Attached to Project: Rockbox
Opened by herz42 - 2006-04-25
Last edited by nicolas_p - 2007-11-13

FS#5234 - lcd brightness for ipod 5g

Backlight pwm controlling is already used for backlight fading on ipod 5g (and some other players).
This patch extends those routines to let the user set the brightness of the enabled lcd backlight.

Some open points:
- the darkest settings (2,3,4) produce some flickering when the cpu is not boosted (eg. on pause).

So maybe the mapping table should be modified a bit.
I have no idea if this is an issue of timer accuracy, on/off time ratios or just some ugly little bug

- the actual fading time for brightness < 100% is shorter than the time in the settings (who cares?)
- the patch is not tested on nano, but I assume it to work
- it can probably be adapted for other ipods with pwm fading
- when adapting to iriver, the cpu would stay boosted all the time while backlight is on (and <100%)
- could continuously pwm’ing the backlight influence player lifetime?
- the patch as it’s now might break some other targets…

So give it a try…

Ralf
Closed by  nicolas_p
2007-11-13 15:40
Reason for closing:  Out of Date
Additional comments about closing:  

The proper implementation is now in SVN.

Jon_ commented on 2006-05-21 21:28

How do you patch?

Jon_ commented on 2006-05-22 18:30

can u patch this for the ipod 5g video please it'll b appriciated since i can't patch files

read this
works VERY WELL if you follow EVERY instruction on this page

http://www.rockbox.org/twiki/bin/view/Main/SimpleGuideToCompiling

ryran commented on 2006-08-24 11:42

For the record, this patch isn't synched so it wouldn't work "very well" if one just followed instructions. It's still doable..however, it requires a little bit of work. If that's the Jon_ I think it is though, he's learned how to compile anyway.

small fix to patch cleanly against current cvs

me dummy!
Applying small fixes isn't always that easy :(
This one should hopefully work…

tried to create a custom build for iPod 5G (60Gb) with this patch [temporarily removed 64Mb buffer patch]. Simulator build is OK. Normal iPod build is OK. Bootloader build is NG! This is my first time to use and install Rockbox so I needed to compile the bootloader. The bootloader build is barfing at:

/usr/bin/ccache arm-elf-gcc -Iinclude -I/home/rommel/linux/build/ipod/rockbox/rockbox.patched/firmware -Iexport -Icommon -Idrivers -I/home/rommel/linux/build/ipod/rockbox/rockbox.patched/build_bootloader -W -Wall -O -nostdlib -ffreestanding -Wstrict-prototypes -mcpu=arm7tdmi -ffunction-sections -mlong-calls -Wno-pointer-sign -fno-strict-aliasing -DIPOD_VIDEO -DYEAR=2006 -DMONTH=09 -DDAY=14 -DBOOTLOADER -DMEM=32 -c backlight.c -o /home/rommel/linux/build/ipod/rockbox/rockbox.patched/build_bootloader/firmware/backlight.o
backlight.c: In function ‘backlight_set_brightness’:
backlight.c:926: error: ‘bl_brightness’ undeclared (first use in this function)
backlight.c:926: error: (Each undeclared identifier is reported only once
backlight.c:926: error: for each function it appears in.)
backlight.c:926: error: ‘bl_brightness_map’ undeclared (first use in this function)

Browsing through your patch I think the definition of bl_brightness and bl_brightness_map is inside a conditional that checks if BOOTLOADER is not defined:

firmware.c:140 #if defined(CONFIG_BACKLIGHT) && !defined(BOOTLOADER)

but later down the file backlight_set_brightness() is defined under a conditional that checks only for CONFIG_BACKLIGHT==IPOD_NANO. If I'm compiling the booloader bl_brightness and bl_brightness_map would be definitely be undefined at any point!

Is the backlight_set_brightness() API used by the bootloader? If not then maybe the API should also be inside a conditional that checks for non BOOTLOADER builds.

The bootloader uses a dedicated routine to just enable the backlight. So the backlight_set_brightness() is not needed for that.
I have added the ~BOOTLOADER condition to make the bootloader build.

Still not sure about eg. the simulation…

BTW: There is a bootloader binary donwload available somewhere on the rockbox page. For safety reasons I'd recommend to use that one.

can someone sync this? the backlight.c has been altered a little.

resynched

Added the configuration defines to enable brightness on iPod nano.

Code builds for nano target, not tested on nano hw yet.

senab commented on 2006-12-23 20:27

I've used it on the Nano for a while back now Ralf, works perfectly.

Works great on my 5.5G 30GB iPod

Needs updating for 20071401 source :p

Senab,

Could you update the patch?

Thank You very much. The brightness feature is very useful and unfortunately the recent source does not support it :(

Woot cheers

OMG!!!!

RALF HERZ THANKS!!!

Sorry, i had to type in caps, i could not contain my happiness!!

Thank You Very Much!!

Hmm this breaks the Mini 2G build.

backlight.c: In function '_backlight_on' :
backlight.c:292: error: 'bl_brightness' undeclared (first use in this function_
backlight.c:292: error: (Each undeclared identifier is reported only once
backlight.c:292: error: for each function it appears in.)

Is it possible to make it Color Target specific?

Also, would it be possible to boost the CPU when the brightness setting is low (i.e. 2-4)?

The flickering for low brightness settings has turned out (in some IRC discussion) to be not CPU-boost related.
If one wanted to improve it, I think the core PWM fading routines (which are not part of this patch) would have to be modified to use on/off timings that are more suitable for iPod video/nano (if it's possible at all).

Regarding Mini 2G build:
Would it make sense to add backlight brightness there, too?

Actually yes it would be a good idea for all targets that have a backlight :D. Its a very nice patch, saves a bit of battery and makes the screen easier on the eyes at night. If you have the time I think it would be greatly appreciated to have adjustable backlight on the targets which support it

The new patch enables backlight brightness for iPod Video/Nano/Mini2G.
At the moment these are the only ones where brightness can be supported relatively easy. The h100 and h120 could too, but those require cpu boosting all the time while dimming so that doesn't seem to be desirable.

I have no Mini2G, so I can't say if the patch works there. At least the target seems to build. Maybe a different scaling of the brightness values would be required for the Mini2G display(?)

I have also tried to add some more #ifdefs to avoid breaking other targets. If your target is still broken by this patch, please let me know.

You should get this approved for SVN :D. Is the 4G Color/Greyscale also supported?

I believe Slasheri has discovered the hardware registers to adjust LCD brightness on the 5gs. Hopefully that solution will find its way into SVN (or at least the patch tracker) soon. Slasheri?

This patch works on my Mini2G. What are you looking for on scaling of brightness values?

Appears to need possibly a rewrite

ryran commented on 2007-05-01 18:34

that's weird… I just patched this against svn yesterday (13295) with no problems.

same here

Enmar commented on 2007-05-27 08:01

okay it is unsynced for the ipod video but fine for the other two… looked at I do not know how to resync it can someone explain… but it is still unsynced, for the ipod video.

senab commented on 2007-06-06 10:06

Simple resync :)

Needs a resync again

Enmar commented on 2007-06-23 23:36

Yes It needs a resync

This is Evilg Comment, Ipod 5/5.5G (30GB / 60GB / 80GB) - EvilG Build Forum entry, Read me about this patch

IMPORTANT: to play doom, and use mpegplayer you will need to set the brightness to 15

Another simple resync. :)

Just noticed compilation errors with the previous two patches. I haven't checked back further and I don't know what problems this causes.

CC backlight.c
backlight.c:203:6: warning: "CONFIG_BACKLIGHT" is not defined
backlight.c:203:24: warning: "BL_IPODNANO" is not defined
backlight.c:240:6: warning: "CONFIG_BACKLIGHT" is not defined
backlight.c:240:24: warning: "BL_IPODNANO" is not defined
backlight.c:344:6: warning: "CONFIG_BACKLIGHT" is not defined
backlight.c:344:24: warning: "BL_IPODNANO" is not defined
backlight.c:881:7: warning: "CONFIG_BACKLIGHT" is not defined
backlight.c:881:25: warning: "BL_IPODNANO" is not defined

with the most recent svn, this patch does not allow the build to compile… I believe they revamped the backlight coding a few builds back…

What platform are you compiling for? It still works for me (iPod Video).

The patch does fail for the iPod Mini 2G, so here's another resync.

The same errors are there as before. I haven't looked into them yet.

Of course I forgot to attach the patch… :)

it now applies perfectly however still erroring out in the building… i am using a nano btw

The errors should be fixed now. I think ideally the code should be moved to the target tree but I can't get my head round that just yet.

Ok, used ipod_brightness_11.patch on svn 29-08-2007
Compile fails with these errors:
CC settings_list.c
settings_list.c:573: error: 'LANG_BRIGHTNESS' undeclared here (not in a function)
settings_list.c:573: warning: missing initializer
settings_list.c:573: warning: (near initialization for 'settings[30].<anonymous>')
settings_list.c:579: warning: missing initializer
settings_list.c:579: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:579: warning: missing initializer
settings_list.c:579: warning: (near initialization for 'settings[31].<anonymous>')
settings_list.c:583: warning: missing initializer
settings_list.c:583: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:583: warning: missing initializer
settings_list.c:583: warning: (near initialization for 'settings[32].<anonymous>')
settings_list.c:589: warning: missing initializer
settings_list.c:589: warning: (near initialization for 'settings[33].<anonymous>')
settings_list.c:591: warning: missing initializer
settings_list.c:591: warning: (near initialization for 'settings[34].<anonymous>')
settings_list.c:594: warning: missing initializer
settings_list.c:594: warning: (near initialization for 'settings[35].<anonymous>')
settings_list.c:607: warning: missing initializer
settings_list.c:607: warning: (near initialization for 'settings[36].<anonymous>')
settings_list.c:609: warning: missing initializer
settings_list.c:609: warning: (near initialization for 'settings[37].<anonymous>')
settings_list.c:611: warning: missing initializer
settings_list.c:611: warning: (near initialization for 'settings[38].<anonymous>')
settings_list.c:621: warning: missing initializer
settings_list.c:621: warning: (near initialization for 'settings[39].<anonymous>')
settings_list.c:625: warning: missing initializer
settings_list.c:625: warning: (near initialization for 'settings[40].<anonymous>')
settings_list.c:627: warning: missing initializer
settings_list.c:627: warning: (near initialization for 'settings[41].<anonymous>')
settings_list.c:630: warning: missing initializer
settings_list.c:630: warning: (near initialization for 'settings[42].<anonymous>')
settings_list.c:631: warning: missing initializer
settings_list.c:631: warning: (near initialization for 'settings[43].<anonymous>')
settings_list.c:632: warning: missing initializer
settings_list.c:632: warning: (near initialization for 'settings[44].<anonymous>')
settings_list.c:633: warning: missing initializer
settings_list.c:633: warning: (near initialization for 'settings[45].<anonymous>')
settings_list.c:637: warning: missing initializer
settings_list.c:637: warning: (near initialization for 'settings[46].<anonymous>')
settings_list.c:640: warning: missing initializer
settings_list.c:640: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:640: warning: missing initializer
settings_list.c:640: warning: (near initialization for 'settings[47].<anonymous>')
settings_list.c:651: warning: missing initializer
settings_list.c:651: warning: (near initialization for 'settings[48].<anonymous>')
settings_list.c:655: warning: missing initializer
settings_list.c:655: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:655: warning: missing initializer
settings_list.c:655: warning: (near initialization for 'settings[49].<anonymous>')
settings_list.c:658: warning: missing initializer
settings_list.c:658: warning: (near initialization for 'settings[50].<anonymous>')
settings_list.c:659: warning: missing initializer
settings_list.c:659: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:659: warning: missing initializer
settings_list.c:659: warning: (near initialization for 'settings[51].<anonymous>')
settings_list.c:663: warning: missing initializer
settings_list.c:663: warning: (near initialization for 'settings[52].<anonymous>')
settings_list.c:664: warning: missing initializer
settings_list.c:664: warning: (near initialization for 'settings[53].<anonymous>')
settings_list.c:666: warning: missing initializer
settings_list.c:666: warning: (near initialization for 'settings[54].<anonymous>')
settings_list.c:668: warning: missing initializer
settings_list.c:668: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:668: warning: missing initializer
settings_list.c:668: warning: (near initialization for 'settings[55].<anonymous>')
settings_list.c:671: warning: missing initializer
settings_list.c:671: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:671: warning: missing initializer
settings_list.c:671: warning: (near initialization for 'settings[56].<anonymous>')
settings_list.c:675: warning: missing initializer
settings_list.c:675: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:675: warning: missing initializer
settings_list.c:675: warning: (near initialization for 'settings[57].<anonymous>')
settings_list.c:681: warning: missing initializer
settings_list.c:681: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:681: warning: missing initializer
settings_list.c:681: warning: (near initialization for 'settings[58].<anonymous>')
settings_list.c:684: warning: missing initializer
settings_list.c:684: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:684: warning: missing initializer
settings_list.c:684: warning: (near initialization for 'settings[59].<anonymous>')
settings_list.c:690: warning: missing initializer
settings_list.c:690: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:690: warning: missing initializer
settings_list.c:690: warning: (near initialization for 'settings[60].<anonymous>')
settings_list.c:703: warning: missing initializer
settings_list.c:703: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:703: warning: missing initializer
settings_list.c:703: warning: (near initialization for 'settings[61].<anonymous>')
settings_list.c:713: warning: missing initializer
settings_list.c:713: warning: (near initialization for 'settings[62].<anonymous>')
settings_list.c:715: warning: missing initializer
settings_list.c:715: warning: (near initialization for 'settings[63].<anonymous>')
settings_list.c:716: warning: missing initializer
settings_list.c:716: warning: (near initialization for 'settings[64].<anonymous>')
settings_list.c:717: warning: missing initializer
settings_list.c:717: warning: (near initialization for 'settings[65].<anonymous>')
settings_list.c:719: warning: missing initializer
settings_list.c:719: warning: (near initialization for 'settings[66].<anonymous>')
settings_list.c:739: warning: missing initializer
settings_list.c:739: warning: (near initialization for 'settings[67].<anonymous>')
settings_list.c:740: warning: missing initializer
settings_list.c:740: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:740: warning: missing initializer
settings_list.c:740: warning: (near initialization for 'settings[68].<anonymous>')
settings_list.c:744: warning: missing initializer
settings_list.c:744: warning: (near initialization for 'settings[69].<anonymous>')
settings_list.c:745: warning: missing initializer
settings_list.c:745: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:745: warning: missing initializer
settings_list.c:745: warning: (near initialization for 'settings[70].<anonymous>')
settings_list.c:749: warning: missing initializer
settings_list.c:749: warning: (near initialization for 'settings[71].<anonymous>')
settings_list.c:752: warning: missing initializer
settings_list.c:752: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:752: warning: missing initializer
settings_list.c:752: warning: (near initialization for 'settings[72].<anonymous>')
settings_list.c:756: warning: missing initializer
settings_list.c:756: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:756: warning: missing initializer
settings_list.c:756: warning: (near initialization for 'settings[73].<anonymous>')
settings_list.c:760: warning: missing initializer
settings_list.c:760: warning: (near initialization for 'settings[74].<anonymous>')
settings_list.c:766: warning: missing initializer
settings_list.c:766: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:766: warning: missing initializer
settings_list.c:766: warning: (near initialization for 'settings[75].<anonymous>')
settings_list.c:777: warning: missing initializer
settings_list.c:777: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:777: warning: missing initializer
settings_list.c:777: warning: (near initialization for 'settings[76].<anonymous>')
settings_list.c:789: warning: missing initializer
settings_list.c:789: warning: (near initialization for 'settings[77].<anonymous>')
settings_list.c:790: warning: missing initializer
settings_list.c:790: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:790: warning: missing initializer
settings_list.c:790: warning: (near initialization for 'settings[78].<anonymous>')
settings_list.c:793: warning: missing initializer
settings_list.c:793: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:793: warning: missing initializer
settings_list.c:793: warning: (near initialization for 'settings[79].<anonymous>')
settings_list.c:803: warning: missing initializer
settings_list.c:803: warning: (near initialization for 'settings[80].<anonymous>')
settings_list.c:804: warning: missing initializer
settings_list.c:804: warning: (near initialization for 'settings[81].<anonymous>')
settings_list.c:808: warning: missing initializer
settings_list.c:808: warning: (near initialization for 'settings[82].<anonymous>')
settings_list.c:811: warning: missing initializer
settings_list.c:811: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:811: warning: missing initializer
settings_list.c:811: warning: (near initialization for 'settings[83].<anonymous>')
settings_list.c:821: warning: missing initializer
settings_list.c:821: warning: (near initialization for 'settings[84].<anonymous>')
settings_list.c:826: warning: missing initializer
settings_list.c:826: warning: (near initialization for 'settings[85].<anonymous>')
settings_list.c:831: warning: missing initializer
settings_list.c:831: warning: (near initialization for 'settings[86].<anonymous>')
settings_list.c:836: warning: missing initializer
settings_list.c:836: warning: (near initialization for 'settings[87].<anonymous>')
settings_list.c:851: warning: missing initializer
settings_list.c:851: warning: (near initialization for 'settings[88].<anonymous>')
settings_list.c:854: warning: missing initializer
settings_list.c:854: warning: (near initialization for 'settings[89].<anonymous>')
settings_list.c:861: warning: missing initializer
settings_list.c:861: warning: (near initialization for 'settings[90].<anonymous>')
settings_list.c:871: warning: missing initializer
settings_list.c:871: warning: (near initialization for 'settings[91].<anonymous>')
settings_list.c:874: warning: missing initializer
settings_list.c:874: warning: (near initialization for 'settings[92].<anonymous>')
settings_list.c:877: warning: missing initializer
settings_list.c:877: warning: (near initialization for 'settings[93].<anonymous>')
settings_list.c:880: warning: missing initializer
settings_list.c:880: warning: (near initialization for 'settings[94].<anonymous>')
settings_list.c:883: warning: missing initializer
settings_list.c:883: warning: (near initialization for 'settings[95].<anonymous>')
settings_list.c:886: warning: missing initializer
settings_list.c:886: warning: (near initialization for 'settings[96].<anonymous>')
settings_list.c:893: warning: missing initializer
settings_list.c:893: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:893: warning: missing initializer
settings_list.c:893: warning: (near initialization for 'settings[97].<anonymous>')
settings_list.c:896: warning: missing initializer
settings_list.c:896: warning: (near initialization for 'settings[98].<anonymous>')
settings_list.c:900: warning: missing initializer
settings_list.c:900: warning: (near initialization for 'settings[99].<anonymous>')
settings_list.c:901: warning: missing initializer
settings_list.c:901: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:901: warning: missing initializer
settings_list.c:901: warning: (near initialization for 'settings[100].<anonymous>')
settings_list.c:904: warning: missing initializer
settings_list.c:904: warning: (near initialization for 'settings[101].<anonymous>')
settings_list.c:906: warning: missing initializer
settings_list.c:906: warning: (near initialization for 'settings[102].<anonymous>')
settings_list.c:909: warning: missing initializer
settings_list.c:909: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:909: warning: missing initializer
settings_list.c:909: warning: (near initialization for 'settings[103].<anonymous>')
settings_list.c:914: warning: missing initializer
settings_list.c:914: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:914: warning: missing initializer
settings_list.c:914: warning: (near initialization for 'settings[104].<anonymous>')
settings_list.c:918: warning: missing initializer
settings_list.c:918: warning: (near initialization for 'settings[105].<anonymous>')
settings_list.c:920: warning: missing initializer
settings_list.c:920: warning: (near initialization for 'settings[106].<anonymous>')
settings_list.c:922: warning: missing initializer
settings_list.c:922: warning: (near initialization for 'settings[107].<anonymous>')
settings_list.c:924: warning: missing initializer
settings_list.c:924: warning: (near initialization for 'settings[108].<anonymous>')
settings_list.c:926: warning: missing initializer
settings_list.c:926: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:926: warning: missing initializer
settings_list.c:926: warning: (near initialization for 'settings[109].<anonymous>')
settings_list.c:931: warning: missing initializer
settings_list.c:931: warning: (near initialization for 'settings[110].<anonymous>')
settings_list.c:933: warning: missing initializer
settings_list.c:933: warning: (near initialization for 'settings[111].<anonymous>')
settings_list.c:936: warning: missing initializer
settings_list.c:936: warning: (near initialization for 'settings[112].<anonymous>')
settings_list.c:939: warning: missing initializer
settings_list.c:939: warning: (near initialization for 'settings[113].<anonymous>')
settings_list.c:942: warning: missing initializer
settings_list.c:942: warning: (near initialization for 'settings[114].<anonymous>')
settings_list.c:946: warning: missing initializer
settings_list.c:946: warning: (near initialization for 'settings[115].<anonymous>')
settings_list.c:947: warning: missing initializer
settings_list.c:947: warning: (near initialization for 'settings[116].<anonymous>')
settings_list.c:950: warning: missing initializer
settings_list.c:950: warning: (near initialization for 'settings[117].<anonymous>')
settings_list.c:953: warning: missing initializer
settings_list.c:953: warning: (near initialization for 'settings[118].<anonymous>')
settings_list.c:956: warning: missing initializer
settings_list.c:956: warning: (near initialization for 'settings[119].<anonymous>')
settings_list.c:959: warning: missing initializer
settings_list.c:959: warning: (near initialization for 'settings[120].<anonymous>')
settings_list.c:962: warning: missing initializer
settings_list.c:962: warning: (near initialization for 'settings[121].<anonymous>')
settings_list.c:966: warning: missing initializer
settings_list.c:966: warning: (near initialization for 'settings[122].<anonymous>')
settings_list.c:969: warning: missing initializer
settings_list.c:969: warning: (near initialization for 'settings[123].<anonymous>')
settings_list.c:972: warning: missing initializer
settings_list.c:972: warning: (near initialization for 'settings[124].<anonymous>')
settings_list.c:975: warning: missing initializer
settings_list.c:975: warning: (near initialization for 'settings[125].<anonymous>')
settings_list.c:978: warning: missing initializer
settings_list.c:978: warning: (near initialization for 'settings[126].<anonymous>')
settings_list.c:982: warning: missing initializer
settings_list.c:982: warning: (near initialization for 'settings[127].<anonymous>')
settings_list.c:985: warning: missing initializer
settings_list.c:985: warning: (near initialization for 'settings[128].<anonymous>')
settings_list.c:988: warning: missing initializer
settings_list.c:988: warning: (near initialization for 'settings[129].<anonymous>')
settings_list.c:991: warning: missing initializer
settings_list.c:991: warning: (near initialization for 'settings[130].<anonymous>')
settings_list.c:994: warning: missing initializer
settings_list.c:994: warning: (near initialization for 'settings[131].<anonymous>')
settings_list.c:999: warning: missing initializer
settings_list.c:999: warning: (near initialization for 'settings[132].<anonymous>')
settings_list.c:1003: warning: missing initializer
settings_list.c:1003: warning: (near initialization for 'settings[133].<anonymous>')
settings_list.c:1004: warning: missing initializer
settings_list.c:1004: warning: (near initialization for 'settings[134].<anonymous>')
settings_list.c:1009: warning: missing initializer
settings_list.c:1009: warning: (near initialization for 'settings[135].<anonymous>')
settings_list.c:1011: warning: missing initializer
settings_list.c:1011: warning: (near initialization for 'settings[136].<anonymous>')
settings_list.c:1014: warning: missing initializer
settings_list.c:1014: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:1014: warning: missing initializer
settings_list.c:1014: warning: (near initialization for 'settings[137].<anonymous>')
settings_list.c:1036: warning: missing initializer
settings_list.c:1036: warning: (near initialization for 'settings[138].<anonymous>')
settings_list.c:1042: warning: missing initializer
settings_list.c:1042: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:1042: warning: missing initializer
settings_list.c:1042: warning: (near initialization for 'settings[139].<anonymous>')
settings_list.c:1060: warning: missing initializer
settings_list.c:1060: warning: (near initialization for 'settings[140].<anonymous>')
settings_list.c:1063: warning: missing initializer
settings_list.c:1063: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:1063: warning: missing initializer
settings_list.c:1063: warning: (near initialization for 'settings[141].<anonymous>')
settings_list.c:1067: warning: missing initializer
settings_list.c:1067: warning: (near initialization for 'settings[142].<anonymous>')
settings_list.c:1071: warning: missing initializer
settings_list.c:1071: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:1071: warning: missing initializer
settings_list.c:1071: warning: (near initialization for 'settings[143].<anonymous>')
settings_list.c:1075: warning: missing initializer
settings_list.c:1075: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:1075: warning: missing initializer
settings_list.c:1075: warning: (near initialization for 'settings[144].<anonymous>')
settings_list.c:1079: warning: missing initializer
settings_list.c:1079: warning: (near initialization for 'settings[145].<anonymous>')
settings_list.c:1083: warning: missing initializer
settings_list.c:1083: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:1083: warning: missing initializer
settings_list.c:1083: warning: (near initialization for 'settings[146].<anonymous>')
settings_list.c:1087: warning: missing initializer
settings_list.c:1087: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:1087: warning: missing initializer
settings_list.c:1087: warning: (near initialization for 'settings[147].<anonymous>')
settings_list.c:1091: warning: missing initializer
settings_list.c:1091: warning: (near initialization for 'settings[148].<anonymous>')
settings_list.c:1095: warning: missing initializer
settings_list.c:1095: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:1095: warning: missing initializer
settings_list.c:1095: warning: (near initialization for 'settings[149].<anonymous>')
settings_list.c:1099: warning: missing initializer
settings_list.c:1099: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:1099: warning: missing initializer
settings_list.c:1099: warning: (near initialization for 'settings[150].<anonymous>')
settings_list.c:1103: warning: missing initializer
settings_list.c:1103: warning: (near initialization for 'settings[151].<anonymous>')
settings_list.c:1107: warning: missing initializer
settings_list.c:1107: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:1107: warning: missing initializer
settings_list.c:1107: warning: (near initialization for 'settings[152].<anonymous>')
settings_list.c:1111: warning: missing initializer
settings_list.c:1111: warning: (near initialization for 'settings[153].<anonymous>')
settings_list.c:1116: warning: missing initializer
settings_list.c:1116: warning: (near initialization for 'settings[154].<anonymous>')
settings_list.c:1118: warning: missing initializer
settings_list.c:1118: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:1118: warning: missing initializer
settings_list.c:1118: warning: (near initialization for 'settings[155].<anonymous>')
settings_list.c:1144: warning: missing initializer
settings_list.c:1144: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:1144: warning: missing initializer
settings_list.c:1144: warning: (near initialization for 'settings[156].<anonymous>')
settings_list.c:1147: warning: missing initializer
settings_list.c:1147: warning: (near initialization for 'settings[157].<anonymous>')
settings_list.c:1149: warning: missing initializer
settings_list.c:1149: warning: (near initialization for 'settings[158].<anonymous>')
settings_list.c:1158: warning: missing initializer
settings_list.c:1158: warning: (near initialization for 'settings[159].<anonymous>')
settings_list.c:1164: warning: missing initializer
settings_list.c:1164: warning: (near initialization for 'settings[160].<anonymous>')
settings_list.c:1172: warning: missing initializer
settings_list.c:1172: warning: (near initialization for 'settings[161].<anonymous>')
settings_list.c:1174: warning: missing initializer
settings_list.c:1174: warning: (near initialization for 'settings[162].<anonymous>')
settings_list.c:1176: warning: missing initializer
settings_list.c:1176: warning: (near initialization for 'settings[163].<anonymous>')
settings_list.c:1182: warning: missing initializer
settings_list.c:1182: warning: (near initialization for 'settings[164].<anonymous>')
settings_list.c:1186: warning: missing initializer
settings_list.c:1186: warning: (near initialization for 'settings[165].<anonymous>')
settings_list.c:1190: warning: missing initializer
settings_list.c:1190: warning: (near initialization for 'settings[166].<anonymous>')
settings_list.c:1193: warning: missing initializer
settings_list.c:1193: warning: (near initialization for 'settings[167].<anonymous>')
settings_list.c:1194: warning: missing initializer
settings_list.c:1194: warning: (near initialization for '(anonymous)[0].<anonymous>')
settings_list.c:1194: warning: missing initializer
settings_list.c:1194: warning: (near initialization for 'settings[168].<anonymous>')
settings_list.c:1221: warning: missing initializer
settings_list.c:1221: warning: (near initialization for 'settings[169].<anonymous>')
settings_list.c:1225: warning: missing initializer
settings_list.c:1225: warning: (near initialization for 'settings[170].<anonymous>')
settings_list.c:1230: warning: missing initializer
settings_list.c:1230: warning: (near initialization for 'settings[171].<anonymous>')
settings_list.c:1232: warning: missing initializer
settings_list.c:1232: warning: (near initialization for 'settings[172].<anonymous>')
settings_list.c:1243: warning: missing initializer
settings_list.c:1243: warning: (near initialization for 'settings[173].<anonymous>')
settings_list.c:1259: warning: missing initializer
settings_list.c:1259: warning: (near initialization for 'settings[174].<anonymous>')
settings_list.c:1262: warning: missing initializer
settings_list.c:1262: warning: (near initialization for 'settings[175].<anonymous>')
make[1]: * [/data/rockbox/svn/build-60-29-08-07-1/apps/settings_list.o] Error 1
make:
* [build] Error 2

Needs a resync ?

sorry about the post above :)
I Missed a file :| strange because it compiled fine without this patch (was a clean svn)….
cleared build directory and got again fresh svn, now it seems to compile.

No, the patch is fine. Try running 'make clean' in the build directory. :)

Seems I posted too late. x)

Hello! I'm from Russia. Can you explain, what exactly should I do, to install this patch on my iPod Nano with Rockbox Daily Build?

I have downloaded .patch file. In what directory should I copy it on my iPod? How can I aply it?

Thank you!

You should read through this wiki page:

http://www.rockbox.org/twiki/bin/view/Main/WebHome?topic=SimpleGuideToCompiling

You might also want to browse through some of the threads in the "Getting Started and Compiling" part of our forum: http://forums.rockbox.org/index.php?board=33.0

Alternately, you might want to browse through the "Unsupported Builds" forum to see if someone has already created a build that incorporates the patch that you are looking for: http://forums.rockbox.org/index.php?board=36.0

We prefer that user support take place in the forums rather than here on the patch tracker, so if you have additional questions, please post a thread in the "Getting Started" forum I linked you to above (or find an existing thread in that forum–there are many–and post a message there). Good luck.

Ok. Thank you!

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing