FS#5291 - preliminary X5 remote support

Attached to Project: Rockbox
Opened by Rani Hod (RaeNye) - Thursday, 04 May 2006, 15:30 GMT
Task Type Patches
Category Remote
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Here's a modification of h100-remote.c; I cannot test any of it as I don't have a RC.

I didn't #define correctly that X5 has a remote in config-x5.h or any other place, so do that.

There're still some things that the preloader does and are not in the code (e.g., exact init sequence, powersave command)
but it should do *something*.

Please test this if you have a X5 remote.
This task depends upon

Closed by  Daniel Stenberg (bagder)
Friday, 07 July 2006, 11:11 GMT
Reason for closing:  Invalid
Additional comments about closing:  Useless patch, don\'t mislead users into thinking this is actually a working remote patch for the X5.
Comment by Marco Alanen (ravon) - Thursday, 04 May 2006, 17:21 GMT
I must have installed it wrong, cause it doesn't even compile for me. Let me (ravon) know if you're available on IRC.
Comment by Daniel Stenberg (bagder) - Thursday, 04 May 2006, 21:07 GMT
1. I called it remote-x5.c and put it among the other x5 drivers in firmware/target/coldfire/iaudio/x5 and added it to SOURCES. It doesn't compile. I get a busload of errors and warnings.

2. Seeing this is more or less just the h100-remote code copied with some minor edits, I fail to see how it can work. X5's remote LCD is 2bit and the h100's is 1bit.

Of course, just adding a C source to the build won't make anything use it but I didn't try anything since it doesn't compile yet.
Comment by boeselhack (boeselhack) - Sunday, 07 May 2006, 09:59 GMT
I tried it yesterday with the remote on my X5L30, but i didn't see any changes.
Maybe i made it wrong:
I save your lcd-h100-remote-rae.c as "lcd-h100-remote.c" in the "firmware" directory and compiled it.
But i could see no changes, nothing on the lcd screen. I only could turn the X5L on and off, but that was also possible with the original version.
BTW: in the todo list od the X5 tasks there is:
Remote button driver (ADC) 100%
Does that mean, that all the buttons of the remote already do work?
Or do i have to enable the remote somewhere in the settings?