Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Codecs
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by timecop - 2006-05-08
Last edited by Buschel - 2011-01-05

FS#5317 - mp3_encoder improperly encodes mono .wav files

when using mp3_encoder plugin on a 44khz mono .wav file, the resulting mp3 plays too fast… <linuxstb> it seems that Stereo input is assumed in lots of places…. The encoder itself seems to support mono, but the Rockbox implementation breaks it.

There’s init_mp3_encoder_engine() which is passed ‘true’ for stereo regardless of actual .wav format, and there’s also some code in the encoding loop which tries to downsample stereo to mono (huh what) if nchannels was set to mono.

Looks like someone got carried away with cut & paste

Closed by  Buschel
2011-01-05 07:54
Reason for closing:  Fixed
Additional comments about closing:  

Fixed with r28971

is this still an issue ?

MikeS commented on 2007-02-02 10:46

It’s been worked out of the adaptation to the encoder framework. If this should be fixed and the transcoder will be kept then I might be able to take care of it.

petur commented on 2007-08-05 00:28

Mike?

Confirmed with e200 & r18013.

MikeS commented on 2008-07-14 06:27

Petur? Isn’t this a plugin issue? I’ve never worked on mp3_encoder. Of course I did say I might be able to take care of it in a post up there I hardly recall making. I must have said it for a good reason though but exactly what it is, my memory gnomes have to go fetch. :)

44.1kHz mono encodes correct with attached patch (also see  FS#10678 ). Nevertheless there is something going wrong with samplerates != 44100. At least a 24kHz mono file encodes strange. Therefor I will not submit this fix and continue work in  FS#10678 .

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing