Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Games
  • Assigned To No-one
  • Operating System All players
  • Severity Very Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Malcohol - 2006-05-13

FS#5356 - Sokoban patch: Unified duplicate code into a function

A sokoban patch: I unified four virtually identical blocks of code into a function. This has no effect on functionality, but it might make the code easier to maintain.

(Aside: Are patches like this too trivial to submit? I’m new to the project, so please tell me if they are :-)

   sokoban.patch (16.8 KiB)
Closed by  bluebrother
2007-02-13 10:13
Reason for closing:  Out of Date
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

closed upon request as superseded by  FS#6625  according to reporter.

Malcohol commented on 2006-05-13 15:53

…in fact, after the above change, I can remove some unnecessary local variables. This new patch replaces the earlier one.

   sokoban.patch (17 KiB)
Malcohol commented on 2006-05-13 18:45

Argh! My first patch was dodgy (iPods don’t define one of button defs I used). Here’s yet another patch. Sorry!

   sokoban.patch (17 KiB)
Malcohol commented on 2007-02-13 09:57

This task can now be closed. It is superseded by  FS#6625  was has
been committed.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing