Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 104 Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /sites/rockbox.org/flyspray/adodb/adodb.inc.php on line 845 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.user.php on line 111 FS#5356 : Sokoban patch: Unified duplicate code into a function

Rockbox

Tasklist

FS#5356 - Sokoban patch: Unified duplicate code into a function

Attached to Project: Rockbox
Opened by Malcolm Tyrrell (Malcohol) - Saturday, 13 May 2006, 15:41 GMT
Task Type Patches
Category Games
Status Closed
Assigned To No-one
Operating System All players
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

A sokoban patch: I unified four virtually identical blocks of code into a function. This has no effect on functionality, but it might make the code easier to maintain.

(Aside: Are patches like this too trivial to submit? I'm new to the project, so please tell me if they are :-)
   sokoban.patch (16.8 KiB)
This task depends upon

Closed by  Dominik Riebeling (bluebrother)
Tuesday, 13 February 2007, 10:13 GMT
Reason for closing:  Out of Date
Additional comments about closing:  closed upon request as superseded by  FS#6625  according to reporter.
Comment by Malcolm Tyrrell (Malcohol) - Saturday, 13 May 2006, 15:53 GMT
...in fact, after the above change, I can remove some unnecessary local variables. This new patch replaces the earlier one.
   sokoban.patch (17 KiB)
Comment by Malcolm Tyrrell (Malcohol) - Saturday, 13 May 2006, 18:45 GMT
Argh! My first patch was dodgy (iPods don't define one of button defs I used). Here's yet another patch. Sorry!
   sokoban.patch (17 KiB)
Comment by Malcolm Tyrrell (Malcohol) - Tuesday, 13 February 2007, 09:57 GMT

This task can now be closed. It is superseded by  FS#6625  was has
been committed.

Loading...