FS#5362 : Bugfix #5159 & #5061 & voice clip bug (jpeg.c)

Status Closed
Percent Complete
100%
Task Type Patches
Category Plugins
Assigned To

bger
Operating System All players
Severity Low
Priority Very Low
Reported Version
Due in Version Undecided
Due Date Undecided
Votes
Private

Attached to Project: Rockbox
Opened by xaviergr - 2006-05-15
Last edited by xaviergr - 2006-05-18

FS#5362 - Bugfix #5159 & #5061 & voice clip bug (jpeg.c)

This small patch fixes bug #5159 and #5061

It removes:
1) A typo that created #5159 (#define JPEG_ZOOM_IN_PRE)
2) JPEG_NEXT_PRE on iPod keymaps which caused #5061
3) #define JPEG_TOGGLE_SLIDESHOW (BUTTON_PLAY|BUTTON_REPEAT) which is no longer used.
4) Fix the way jpeg viewer will interact in case a voice clip is played.

The task blocks these from closing
ID	Project	Summary	Priority	Severity	Assigned To	Progress
5061	Rockbox	~~FS#5061 - JPEG viewer - next image when zoomed in does not work~~	Very Low	Low		100%
5159	Rockbox	~~FS#5159 - JPEG viewer plugin can't zoom out on iAudio X5, key bounces.~~	Very Low	Low		100%

Closed by linuxstb
2006-05-20 13:47
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Added to CVS - thanks.

Comments (3)
Related Tasks (0/0)

xaviergr commented on 2006-05-17 13:38

I upddated this patch to:
1) Fix a bug in the sim reported by Bill Janssen on the dev-mailing list.
2) Fix the way jpeg viewer will interact in case a voice clip is played.

xaviergr commented on 2006-05-17 13:41

Oops forgot to add the diff file.

xaviergr commented on 2006-05-18 12:11

Bug reported by Bill Jansen is commited.
New patch (without Bill Jansen’s fix)