FS#5362 : Bugfix #5159 & #5061 & voice clip bug (jpeg.c)

FS#5362 - Bugfix #5159 & #5061 & voice clip bug (jpeg.c)

Attached to Project: Rockbox
Opened by Alexander Spyridakis (xaviergr) - Monday, 15 May 2006, 01:35 GMT
Last edited by Alexander Spyridakis (xaviergr) - Thursday, 18 May 2006, 12:06 GMT

Task Type	Patches
Category	Plugins
Status	Closed
Assigned To	Hristo Kovachev (bger)
Operating System	All players
Severity	Low
Priority	Normal
Reported Version
Due in Version	Undecided
Due Date	Undecided
Percent Complete
Votes	0
Private	No

Details

This small patch fixes bug #5159 and #5061

It removes:
1) A typo that created #5159 (#define JPEG_ZOOM_IN_PRE)
2) JPEG_NEXT_PRE on iPod keymaps which caused #5061
3) #define JPEG_TOGGLE_SLIDESHOW (BUTTON_PLAY|BUTTON_REPEAT) which is no longer used.
4) Fix the way jpeg viewer will interact in case a voice clip is played.

This task depends upon

View Dependency Graph

This task blocks these from closing
~~FS#5061 - JPEG viewer - next image when zoomed in does not work~~
~~FS#5159 - JPEG viewer plugin can't zoom out on iAudio X5, key bounces.~~

Closed by Dave Chapman (linuxstb)
Saturday, 20 May 2006, 13:47 GMT
Reason for closing: Accepted
Additional comments about closing: Added to CVS - thanks.

Comments (3)
Related Tasks (0/0)

Comment by Alexander Spyridakis (xaviergr) - Wednesday, 17 May 2006, 13:38 GMT

I upddated this patch to:
1) Fix a bug in the sim reported by Bill Janssen on the dev-mailing list.
2) Fix the way jpeg viewer will interact in case a voice clip is played.

Comment by Alexander Spyridakis (xaviergr) - Wednesday, 17 May 2006, 13:41 GMT

Oops forgot to add the diff file.

Comment by Alexander Spyridakis (xaviergr) - Thursday, 18 May 2006, 12:11 GMT

Bug reported by Bill Jansen is commited.
New patch (without Bill Jansen's fix)

jpeg.diff (2.2 KiB)

	Tasks related to this task (0)

Duplicate tasks of this task (0)

Rockbox

FS#5362 - Bugfix #5159 & #5061 & voice clip bug (jpeg.c)

Details

Loading...