• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Plugins
  • Assigned To
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by xaviergr - 2006-05-15
Last edited by xaviergr - 2006-05-18

FS#5362 - Bugfix #5159 & #5061 & voice clip bug (jpeg.c)

This small patch fixes bug #5159 and #5061

It removes:
1) A typo that created #5159 (#define JPEG_ZOOM_IN_PRE)
2) JPEG_NEXT_PRE on iPod keymaps which caused #5061
3) #define JPEG_TOGGLE_SLIDESHOW (BUTTON_PLAY|BUTTON_REPEAT) which is no longer used.
4) Fix the way jpeg viewer will interact in case a voice clip is played.

The task blocks these from closing
ID Project Summary Priority Severity Assigned To Progress
5061 Rockbox  FS#5061 - JPEG viewer - next image when zoomed in does not work  Very Low Low
5159 Rockbox  FS#5159 - JPEG viewer plugin can't zoom out on iAudio X5, key bounces.  Very Low Low
Closed by  linuxstb
2006-05-20 13:47
Reason for closing:  Accepted
Additional comments about closing:  

Added to CVS - thanks.

I upddated this patch to:
1) Fix a bug in the sim reported by Bill Janssen on the dev-mailing list.
2) Fix the way jpeg viewer will interact in case a voice clip is played.

Oops forgot to add the diff file.

Bug reported by Bill Jansen is commited.
New patch (without Bill Jansen’s fix)


Available keyboard shortcuts


Task Details

Task Editing