FS#5509 - Star game uses too little screen space

Attached to Project: Rockbox
Opened by Anonymous Submitter - Wednesday, 07 June 2006, 00:44 GMT
Last edited by Ben Basha (paprica) - Wednesday, 21 June 2006, 13:30 GMT
Task Type Bugs
Category Games
Status Closed
Assigned To Antoine Cellerier (dionoea)
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


The game Star utilizes about 1/3 of the screen (at least on the iRiver H120). This makes it very uncomfortable to play, as all the objects are too small. Making everything bigger would probably be a lot easier on the eyes, and screen space would not be wasted. Is this possible?
This task depends upon

Closed by  Shachar (Lamed)
Friday, 11 August 2006, 11:50 GMT
Reason for closing:  Fixed
Comment by Dave Chapman (linuxstb) - Wednesday, 21 June 2006, 12:35 GMT
AFAIK, the star plugin has only been fixed for the colour LCDs - it's still only utilizing a small part of the display on the greyscale LCDs such as the H1x0 and the greyscale ipods.
Comment by Antoine Cellerier (dionoea) - Thursday, 27 July 2006, 22:09 GMT
Should be fixed for greyscale LCD targets.
Comment by Robert Kukla (roolku) - Friday, 28 July 2006, 12:10 GMT
Thank you for your update.

- unfortunately the bmp file has been commited as 'text' and not 'binary' which means on pc platforms all 0x0a are replaced by 0x0d 0x0a by the cvs client (I took a uncorrupted copy from the bleeding edge.bz2)

- also the dark gray is too close to black, so it is very difficult to actually see the maze - would it be possible to change that to light gray or change the colour scheme completely?

- the game speed is very, very slow - is this an issue with the screen redraw or is there a delay in the game that can be adapted?

Comment by Antoine Cellerier (dionoea) - Friday, 28 July 2006, 14:42 GMT
woops, i'll fix the bitmap (maybe make it more contrasted).

About the game speed: it depends on the LCD driver's speed. You can try changing the STAR_SLEEP define at the begining of the file. We currently slow down the game for all the targets except the iPod Video. Tell me what values work best for the h1x0 and i'll change those.
Comment by Antoine Cellerier (dionoea) - Friday, 28 July 2006, 21:27 GMT
The bitmap should now be fixed. Tell me if it looks better (if it still doesn't, please make a new one :) )
Comment by Dave Hooper (stripwax) - Friday, 28 July 2006, 22:44 GMT
Any chance the game speed could depend on a timer rather than the LCD driver speed? Last I tried it was really very very slow on the ipod video platform..
Comment by Antoine Cellerier (dionoea) - Friday, 28 July 2006, 22:51 GMT
It's definitively an LCD driver speed issue on the ipod (if you look at the source code, you can see that the sleep() call is disabled for the Video ipod). Speed could be improved a bit by making the ball move by 2px steps which would require half the number of lcd rectange update.
Comment by Robert Kukla (roolku) - Friday, 28 July 2006, 23:23 GMT
- unfortunately the greylevels are fixed for the h120 display, so changing the contrast of the bitmap doesn't make a difference - I have swapped light-grey and dark-grey around and it works now, although someone with artistic talent can probably improve it more by adding some shading/texture.

- sleep(0.2) gives the best results in my opinion - not so slow that you fall asleep, but still visible moves/animation

Comment by Dave Hooper (stripwax) - Saturday, 29 July 2006, 00:02 GMT
Yes - indeed I do mean "could the plugin be updated to *use* a timer to control the speed of the ball [say, one maze unit per 0.5 seconds], rather than always move the ball in one pixel increments and rely on the LCD driver to control the speed of the game". I don't expect that would be a difficult change (in fact I'd do it myself if I had time to do so)
Comment by Shachar (Lamed) - Thursday, 10 August 2006, 18:41 GMT
would you mind if this task will be closed?
Comment by Robert Kukla (roolku) - Thursday, 10 August 2006, 18:51 GMT
Not sure who you are asking, but on the h120 it is still unplayable because of the slow speed and darkgray<->black similarity. (see my comment above).
Comment by Shachar (Lamed) - Thursday, 10 August 2006, 21:03 GMT
for now i've made the game as fast it could be, unless not using the animation at all. I think you should update your files because the game is very playable as it is now on h120, no dark-grey problem for me.

btw I was discussing amiconn on IRC about the dark grey, but I can't seem to see the changes that he made for the dark grey to be brighter.

I was asking whether everyone is happy with the game or this FS should remain open, so please update your files and let me know.
Comment by Robert Kukla (roolku) - Friday, 11 August 2006, 10:51 GMT
All seems fine now. Thanks for your efforts.