• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category User Interface → Language
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Lamed - 2006-06-22

FS#5587 - Hebrew translation Major update


Rockbox’s internal font can’t display special characters such as hebrew characters. That’s why hebrew translation couldn’t be really used: the recording menu, quickscreen, the equalizer and so on displayed corrupted text instead of real characters.

This patch changes LANG strings to LANG_SYSFONT strings, wherever theres a string that will be displayed in rockbox internal font,
The patch will also add the missing strings to all other languages, so there is virtually no other work then patching hebrew_sysfont_lang_justpatch.diff against the cvs source.

i’m also encapsulating the script I’ve used to add the new strings to all languages. to use it, patch hebrew_sysfont_lang_upsys.diff against the source, copy the files to rockbox/apps/lang/ , and run upsys from rockbox/apps/lang. there is a good description of how language files where updated inside upsys file.

the patch was tested on virtually all targets.

I suggest that for the future rockbox will keep using different LANG_SYSFONT_ phrases for strings that will use the system font, or at least until sysfont will support UTF…

This is a very big enhancement for the non-latin-characters readers for version 3.0, I’ve put many hours into this (and about 12 hours stright for the upsys script…)

Good Night!!

Closed by  Lamed
2006-08-07 22:54
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

accepted, for now. jens arnold has objected to it because of increase in binary size. It will either be totally discarded or by the time we no longer have the internal font used in a couple of screens.

Lamed commented on 2006-06-23 02:39

I think the patchfile was currupted, sorry. Use the following:

Lamed commented on 2006-06-29 14:02

Accept This Patch Immediately!

(Daniel, I’ve figured you’re very quick on rejecting trackers on request, so you might as well.. :P )

Lamed commented on 2006-07-09 21:45

patch hebrew_sysfont_lang_upsys.diff against the source,
run upsys from rockbox/apps/lang.
(you might need to chmod +x it)


Available keyboard shortcuts


Task Details

Task Editing