Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Music playback
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by rotator - 2006-06-27

FS#5602 - Allow wav files with 'fmt ' chunk past MAX_PATH bytes

Currently Rockbox is unable to play WAV files that have a large header before the ‘fmt ' chunk. For example, wav files created with Pro-Tools or Wavelab will not work. This is due to a problem in both the wav codec and the wav metadata parser. The wav codec assumes the ‘fmt ' chunk is within the first 1024 bytes of the file and even worse, the metadata parser assumes it’s within the first MAX_PATH bytes.

This patch allows for the ‘fmt ' chunk to be located at any arbitrary location in the file as long as it still appears before the ‘data’ chunk. This fixes the problem and sample file from the forums: http://forums.rockbox.org/index.php?topic=3381.0

(application/octet-stream)    wav.patch (6.3 KiB)
Closed by  rotator
2006-06-27 22:44
Reason for closing:  Accepted
rotator commented on 2006-06-27 02:59

I’d appreciate it if someone could look over and test this patch to make sure I didn’t break anything. If everything looks ok, would it be alright if I committed this since it’s a bugfix that impacts 3.0 targets?

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing