Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Remote
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Version 3.0
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Martin Scarratt - 2006-06-29
Last edited by Martin Scarratt - 2006-06-29

FS#5615 - settings.h modification for easier remote implementation

Small change defining remote buttons in settings.h

Closed by  Peter D'Hoye
2006-07-01 00:22
Reason for closing:  Accepted
Additional comments about closing:  

check the committed code to see how it\'s supposed to be done. If not clear, read irc log of 20060701 starting 01:36 ;)

Peter D'Hoye commented on 2006-06-29 22:23

this patch has no functionality, right?
It just creates defines that are nowhere used…

or do I miss something?

Martin Scarratt commented on 2006-06-30 08:14

Yep…that’s right… It’s just that in the other patches for remote support I’ll use it, so it would make my life easier creating patches and testing if it was already committed.

Peter D'Hoye commented on 2006-06-30 08:18

I think it would be better to include this with the first patch that actually uses them

Martin Scarratt commented on 2006-06-30 08:34

Oh bugger…but then I have to change code, add this patch, test the code remove the patch and then make a new patch! my fingers are getting sore! ;)

Also the patches I’m making on flyspray don’t work unless you install this one too. I could include it in every patch but then I would have to change them all as soon as one is committed! Life is hard eh?

Peter D'Hoye commented on 2006-06-30 08:47

submit a simple patch that includes this one, and continue once it is committed?
*maybe* I have a bit of time to look at it sunday evening….

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing