Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category LCD
  • Assigned To No-one
  • Operating System Iriver H100 series
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Andreas Mattsson - 2006-07-02
Last edited by Alex Parker - 2010-06-05

FS#5627 - H100 grayscale bitmap fix

Updates the iriver H100 LCD-driver so as to make the handling of 4-gray bitmaps analogous to its monochrome bitmap-handling. This means the white pixels of an image are no longer drawn on top of other images.
Useful for WPS as it allows you to place grayscale bitmaps behind other bitmaps and properly display text on top of grayscale bitmaps. This was previously not possible.

Changes were made to the lcd_bitmap_part function in lcd-h100.c and the function setblock was removed as it no longer was used.
I’d like it if this was included in CVS.

Closed by  Alex Parker
2010-06-05 16:44
Reason for closing:  Out of Date
Andreas Mattsson commented on 2006-07-03 08:32

Ok, I’ve now applied the same fix to the iPod 4-gray driver (lcd-2bit-horz.c). Here’s the iPod patch and combined (iriver+iPod) batch.

Admin
Linus Nielsen Feltzing commented on 2006-07-03 08:46

OK, so this patch makes white pixels transparent?

I would prefer if the grayscale drivers implemented the same mask color approach as the color targets. However, this is definitely a step in the right direction. Could you please submit a new patch without the MSDOS newlines and the TAB characters?

Andreas Mattsson commented on 2006-07-03 09:31

I didn’t really look into how color targets handle transparency. My main goal was to make it so that monochrome vs grayscale bitmaps could work interchangably with the same behaviour thinking it would make sense for you to for example be able to swap out the monochrome bitmaps of a WPS for grayscale versions without everything getting screwed up…

Did a find-and-replace for tab characters and ran dos2unix for the 2 source files. Here are the new patches.

Admin
Linus Nielsen Feltzing commented on 2006-07-03 09:47

Have you made any performance tests other than the WPS, like some of the plugins?

Andreas Mattsson commented on 2006-07-03 10:32

Ok, I’m a total rockbox dev n00b (this is my first patch) so by performance testing what exactly do you mean? Is there some debug mode to show framerates or something I should use? I’ve done a search for all source files that use lcd_bitmap(), lcd_bitmap_part(), screen→bitmap() or screen→bitmap_part() and have tried out all the plugins that do - noticing no difference. But is there any way to get actual performance figures for comparison?

Andreas Mattsson commented on 2006-07-03 10:37

only limited testing on the iPod though as I don’t have one myself… (only tested using simulator)

Andreas Mattsson commented on 2006-07-20 13:42
Andreas Mattsson commented on 2006-08-16 08:47

updated to CVS (wont bother making separate patches for h100 and ipod anymore, this one includes both)

Jonas Häggqvist commented on 2008-12-14 20:03

I’m pretty sure this is both horribly out of date, and unneeded, since I don’t think there’s a need for this because of viewports/backgrounds etc: “Useful for WPS as it allows you to place grayscale bitmaps behind other bitmaps and properly display text on top of grayscale bitmaps. This was previously not possible.”

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing