• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category Battery/Charging
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Lamed - 2006-07-10

FS#5640 - Custom keyboard - better embed and solves bugs.

This is my last patch i’ve been working on at the last week.
The virtual keyboard have had some time ago some new features implemented into, but they were very uncomfortable to use. my patch improves many things.

* switching between the default and custom (loaded) keyboard buffer.
user: If player has a button to flip pages, it will now first flip pages on the same buffer, and at the last page it will flip to the next buffer.

    if not, player flips pages on left and right screen edges, and flips keyboard buffers on up/down edges.

code: There’s a new buffer defined in keyboard.c, static unsigned short custom_kbd_buf[KBD_BUF_SIZE]. the load_kbd function loads the table into that buffer. that way we can switch between the two buffers without reloading an external file every time.

* custom keyboard buffer treats on newlines.
user: whether you use windows or linux, just write a file in your own native lanugage, with whatever keys you need; you wouldn’t get one long line with all the characters that you choose.
code: the new custom_kbd_buf is loaded into kbd_buf, (just like the default_kbd keyboard buffer does) so we can act on newlines.

* code cleanups
code: there where some functions that where run when they shouldn’t have run at all, or should have run just once.

* fix a global settings bug.
code: settings.c and filetree.c treat .kbd extension files in a wrong way, causing the loaded custom keyboard not to be saved in a configuration file, or loaded in a fresh boot or a settings load. it’s fixed.

Closed by  nls
2006-07-10 19:50
Reason for closing:  Invalid
Lamed commented on 2006-07-10 01:08

dammit. i was hasty. please close this one and i’ll open a patch


Available keyboard shortcuts


Task Details

Task Editing