FS#5665 - patch for english.lang bug in iriver players yes/no screen

Attached to Project: Rockbox
Opened by Jenna Fox (CreativePony) - Saturday, 15 July 2006, 09:13 GMT
Last edited by Jonathan Gordon (jdgordon) - Saturday, 15 July 2006, 09:46 GMT
Task Type Patches
Category Language
Status Closed
Assigned To No-one
Operating System Iriver H100 series
Severity High
Priority Normal
Reported Version
Due in Version Version 3.0
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


I've never contributed to rockbox before, but I've compiled this and it works fine on my h140, its fixing a bug where the Select button activates the Yes command in yes/no screen's, while without this patch, the latest build (not cvs) would display a message saying that the PLAY button would do this, which would actually activate No

I hope I've done this diff/patch thingy right, as I've never made one before
This task depends upon

Closed by  Matthias Mohr (aka Massa) (mmohr)
Sunday, 30 July 2006, 14:12 GMT
Reason for closing:  Duplicate
Additional comments about closing:  Seems to be the same patch as
 FS#5364  — \"NAVI = Yes\" for H300 / \"SELECT = Yes\" for H100/H120 (most languages)
so I closed this one here...
Comment by Jenna Fox (CreativePony) - Saturday, 15 July 2006, 09:30 GMT
Added another change by request from jdGordon, changing it to NAVI on h300's instead of PLAY also.. I haven't recompiled to test this, but it should be fine?
Comment by Paul Louden (darkkone) - Saturday, 15 July 2006, 19:00 GMT
Well, technically the key should be called "NAVI" on H100/120s as well.

Out of curiosity (since my remote is broken) is it the NAVI key on the remote as well?
Comment by Jenna Fox (CreativePony) - Saturday, 15 July 2006, 21:36 GMT
This is what I thought.. I have a US h140 and its always officially been called NAVI to me.. from all the confusion about, I wonder if maybe the European models call it SELECT? On my h140 remove, there is a 'NAVI / MENU' action in pressing down the top left wheel thing..

Personally I don't mind much, select seems like a nicer name anyway, and if we change it here, it would need to be updated in a LOT of other places too (especially the h120/140 manual)
Comment by Jenna Fox (CreativePony) - Saturday, 15 July 2006, 21:38 GMT
er, thats supposed to read "On my h140 remote, [...]"
Comment by Jenna Fox (CreativePony) - Saturday, 15 July 2006, 22:03 GMT
I've looked up the Eauropean h140 manual through the iRiver website.. It calls the button NAVI too..
Comment by Dominik Riebeling (bluebrother) - Saturday, 15 July 2006, 22:19 GMT
CreativePony, updating the name in the manual will be a piece of cake as we have heavily macrofied it :)
For the naming discussion, I own a EU H120, and I'm pretty much used to that key as "select" -- mainly because I usually dont use the remote (which labels it as "Navi / Menu" on my device as well, so it seems to be identical for EU and US models).
As the button isn't labelled at all on the device I'd personally prefer using "select" as it seems more natural to me. But as the remote calls it "navi" maybe we should consider renaming it to "navi". Another option would be to name this fact for the remote in the manual when we manage to write a section about the h100 remote.
Comment by Paul Louden (darkkone) - Saturday, 15 July 2006, 22:21 GMT
I'd actually be happier calling the key "Select" universally, and then noting in an early section of the manual (maybe a "Basic notes for migrating from the retail firmware" or something) noting that the NAVI button is referred to as Select as well in Rockbox.

Since we use Select to identify the center button on the iPod, as well as it probably being useful for the generic "Invoke" button on any future players that might have one, it keeps it a bit more consistent across targets too.
Comment by Jenna Fox (CreativePony) - Saturday, 15 July 2006, 22:26 GMT
I like that idea too.. it would be nice because someone with an iRiver can tell someone with an iPod which buttons to press on their iPod or Archos or whatever they may have.. The downside is units that explicitly label the button, like the h300..
Comment by Jonathan Gordon (jdgordon) - Monday, 24 July 2006, 06:48 GMT
ive fixed the patch up so it will (hopefully) work automatically with my web compiler thingy
Comment by Jonathan Gordon (jdgordon) - Sunday, 30 July 2006, 01:40 GMT
just putting a note here to hold off commiting this for a bit.. (not that its really needed :p )
if my button changes get introduced the iviers will be using on for this screen so this wont be needed.