Index: apps/recorder/bmp.c =================================================================== --- apps/recorder/bmp.c (revision 18166) +++ apps/recorder/bmp.c (working copy) @@ -170,6 +170,51 @@ int read_bmp_file(const char* filename, return ret; } +#ifdef HAVE_ALBUMART +int get_bmp_size(int fd, struct bitmap *bmp) +{ + struct bmp_header bmph; + + int ret = read(fd, &bmph, sizeof(struct bmp_header)); + + if (ret < 0) + return ret * 10 - 2; + + if (ret != sizeof(struct bmp_header)) { + DEBUGF("get_bmp_size: can't read BMP header."); + return -3; + } + + bmp->width = readlong(&bmph.width); + bmp->height = readlong(&bmph.height); + + /* Top-down BMP file */ + if (bmp->height < 0) + bmp->height = -bmp->height; + + if (-1 == lseek(fd, -ret, SEEK_CUR)) + return 0; + + return get_bmp_file_size(bmp); +} +#endif /* HAVE_ALBUMART */ + +static struct mutex bmpbuf_mutex; + +void bmp_init(void) +{ + mutex_init(&bmpbuf_mutex); +} + + +#define LIMIT_WIDTH (1280) +#if (LCD_WIDTH < LIMIT_WIDTH) +#define MAX_WIDTH LIMIT_WIDTH +#else +#define MAX_WIDTH LCD_WIDTH +#endif +static uint32_t bmpbuf[LCD_WIDTH]; /* Buffer for one line */ + /****************************************************************************** * read_bmp_fd() * @@ -190,7 +235,6 @@ int read_bmp_fd(int fd, int rowstart, rowstop, rowstep; unsigned char *bitmap = bm->data; - uint32_t bmpbuf[LCD_WIDTH]; /* Buffer for one line */ uint32_t palette[256]; #if (LCD_DEPTH > 1) || defined(HAVE_REMOTE_LCD) && (LCD_REMOTE_DEPTH > 1) bool transparent = false; @@ -232,9 +276,9 @@ int read_bmp_fd(int fd, } width = readlong(&bmph.width); - if (width > LCD_WIDTH) { + if (width > MAX_WIDTH) { DEBUGF("read_bmp_fd: Bitmap too wide (%d pixels, max is %d)\n", - width, LCD_WIDTH); + width, MAX_WIDTH); return -4; } @@ -377,11 +421,14 @@ int read_bmp_fd(int fd, union rgb_union *qp; union rgb_union q0, q1; + mutex_lock(&bmpbuf_mutex); + /* read one row */ ret = read(fd, bmpbuf, padded_width); if (ret != padded_width) { DEBUGF("read_bmp_fd: error reading image, read returned: %d " "expected: %d\n", ret, padded_width); + mutex_unlock(&bmpbuf_mutex); return -9; } @@ -584,6 +631,8 @@ int read_bmp_fd(int fd, if (brightness(*qp++) < 128) *p |= mask; } + mutex_unlock(&bmpbuf_mutex); + } return totalsize; /* return the used buffer size. */ Index: apps/recorder/bmp.h =================================================================== --- apps/recorder/bmp.h (revision 18166) +++ apps/recorder/bmp.h (working copy) @@ -23,6 +23,7 @@ #include "config.h" #include "lcd.h" +#include "debug.h" /********************************************************************* * read_bmp_file() @@ -41,4 +42,33 @@ int read_bmp_fd(int fd, struct bitmap *bm, int maxsize, int format); + +#ifdef HAVE_ALBUMART +static inline int get_bmp_file_size(struct bitmap *bmp) +{ + int width = bmp->width, height = bmp->height; + int dst_width, dst_height; + +#if LCD_DEPTH == 2 +#if LCD_PIXELFORMAT == HORIZONTAL_PACKING + dst_width = (width + 3) >> 2; + dst_height = height; +#elif LCD_PIXELFORMAT == VERTICAL_PACKING + dst_width = width; + dst_height = (height + 3) >> 2; +#elif LCD_PIXELFORMAT == VERTICAL_INTERLEAVED + dst_width = width; + dst_height = (height + 7) >> 3; +#endif /* LCD_PIXELFORMAT */ +#elif LCD_DEPTH == 16 + dst_width = width; + dst_height = height; +#endif /* LCD_DEPTH */ + + return dst_width * dst_height * sizeof(fb_data); +} + +int get_bmp_size(int fd, + struct bitmap *bmp); +#endif /* HAVE_ALBUMART */ #endif Index: apps/recorder/albumart.c =================================================================== --- apps/recorder/albumart.c (revision 18166) +++ apps/recorder/albumart.c (working copy) @@ -30,7 +30,9 @@ #include "debug.h" #include "misc.h" #include "settings.h" +#include "bmp.h" +#define SCALE 1000 /* Strip filename from a full path * @@ -297,3 +299,41 @@ void draw_album_art(struct gui_wps *gwps gwps->display->set_drawmode(DRMODE_SOLID); } } + +int get_albumart_size(struct bitmap *dst_bmp, struct bitmap *src_bmp) +{ + struct wps_data *data = gui_wps[0].data; + + short aa_max_width = data->albumart_max_width; + short aa_max_height = data->albumart_max_height; + const short width = src_bmp->width; + const short height = src_bmp->height; + + if (aa_max_width < 0 || aa_max_height < 0 || width <= 0 || height <= 0) + return 0; + + if (aa_max_width == 0) + aa_max_width = width; + if (aa_max_height == 0) + aa_max_height = height; + + if ((aa_max_width == width) && (aa_max_width == width)) { + dst_bmp->width = width; + dst_bmp->height = height; + } else { + /* + * keep aspect ratio + * because resize fanction doesn't keep aspect rate + */ + const unsigned short factx = aa_max_width * SCALE / width; + const unsigned short facty = aa_max_height * SCALE / height; + const unsigned short fact = MIN(factx, facty); + + dst_bmp->width = (width * fact + SCALE/2) / SCALE; /* round off */ + dst_bmp->height = (height * fact + SCALE/2) / SCALE; /* round off */ + } + + DEBUGF("get_albumart_size: %d\n",get_bmp_file_size(dst_bmp)); + + return get_bmp_file_size(dst_bmp); +} Index: apps/recorder/albumart.h =================================================================== --- apps/recorder/albumart.h (revision 18166) +++ apps/recorder/albumart.h (working copy) @@ -40,6 +40,8 @@ void draw_album_art(struct gui_wps *gwps bool search_albumart_files(const struct mp3entry *id3, const char *size_string, char *buf, int buflen); +int get_albumart_size(struct bitmap *dst_bmp, struct bitmap *src_bmp); + #endif /* HAVE_ALBUMART */ #endif /* _ALBUMART_H_ */ Index: apps/gui/gwps.c =================================================================== --- apps/gui/gwps.c (revision 18166) +++ apps/gui/gwps.c (working copy) @@ -804,6 +804,9 @@ static void statusbar_toggle_handler(voi void gui_sync_wps_init(void) { int i; +#ifdef HAVE_LCD_BITMAP + bmp_init(); +#endif FOR_NB_SCREENS(i) { wps_data_init(&wps_datas[i]); Index: apps/gui/wps_parser.c =================================================================== --- apps/gui/wps_parser.c (revision 18166) +++ apps/gui/wps_parser.c (working copy) @@ -886,13 +886,6 @@ static int parse_albumart_load(const cha { const char *_pos, *newline; bool parsing; - const short xalign_mask = WPS_ALBUMART_ALIGN_LEFT | - WPS_ALBUMART_ALIGN_CENTER | - WPS_ALBUMART_ALIGN_RIGHT; - const short yalign_mask = WPS_ALBUMART_ALIGN_TOP | - WPS_ALBUMART_ALIGN_CENTER | - WPS_ALBUMART_ALIGN_BOTTOM; - (void)token; /* silence warning */ /* reset albumart info in wps */ @@ -902,7 +895,7 @@ static int parse_albumart_load(const cha wps_data->albumart_xalign = WPS_ALBUMART_ALIGN_CENTER; /* default */ wps_data->albumart_yalign = WPS_ALBUMART_ALIGN_CENTER; /* default */ - /* format: %Cl|x|y|[[l|c|r][d|i|s]mwidth]|[[t|c|b][d|i|s]mheight]| */ + /* format: %Cl|x|y|[[l|c|r]mwidth]|[[t|c|b]mheight]| */ newline = strchr(wps_bufptr, '\n'); @@ -937,36 +930,25 @@ static int parse_albumart_load(const cha case 'l': case 'L': case '+': - wps_data->albumart_xalign = - (wps_data->albumart_xalign & xalign_mask) | - WPS_ALBUMART_ALIGN_LEFT; + wps_data->albumart_xalign = WPS_ALBUMART_ALIGN_LEFT; break; case 'c': case 'C': - wps_data->albumart_xalign = - (wps_data->albumart_xalign & xalign_mask) | - WPS_ALBUMART_ALIGN_CENTER; + wps_data->albumart_xalign = WPS_ALBUMART_ALIGN_CENTER; break; case 'r': case 'R': case '-': - wps_data->albumart_xalign = - (wps_data->albumart_xalign & xalign_mask) | - WPS_ALBUMART_ALIGN_RIGHT; + wps_data->albumart_xalign = WPS_ALBUMART_ALIGN_RIGHT; break; case 'd': case 'D': - wps_data->albumart_xalign |= WPS_ALBUMART_DECREASE; - break; case 'i': case 'I': - wps_data->albumart_xalign |= WPS_ALBUMART_INCREASE; - break; case 's': case 'S': - wps_data->albumart_xalign |= - (WPS_ALBUMART_DECREASE | WPS_ALBUMART_INCREASE); - break; + /* simply ignored */ + break; default: parsing = false; break; @@ -997,36 +979,25 @@ static int parse_albumart_load(const cha case 't': case 'T': case '-': - wps_data->albumart_yalign = - (wps_data->albumart_yalign & yalign_mask) | - WPS_ALBUMART_ALIGN_TOP; + wps_data->albumart_yalign = WPS_ALBUMART_ALIGN_TOP; break; case 'c': case 'C': - wps_data->albumart_yalign = - (wps_data->albumart_yalign & yalign_mask) | - WPS_ALBUMART_ALIGN_CENTER; + wps_data->albumart_yalign = WPS_ALBUMART_ALIGN_CENTER; break; case 'b': case 'B': case '+': - wps_data->albumart_yalign = - (wps_data->albumart_yalign & yalign_mask) | - WPS_ALBUMART_ALIGN_BOTTOM; + wps_data->albumart_yalign = WPS_ALBUMART_ALIGN_BOTTOM; break; case 'd': case 'D': - wps_data->albumart_yalign |= WPS_ALBUMART_DECREASE; - break; case 'i': case 'I': - wps_data->albumart_yalign |= WPS_ALBUMART_INCREASE; - break; case 's': case 'S': - wps_data->albumart_yalign |= - (WPS_ALBUMART_DECREASE | WPS_ALBUMART_INCREASE); - break; + /* simply ignored */ + break; default: parsing = false; break; Index: apps/gui/gwps.h =================================================================== --- apps/gui/gwps.h (revision 18166) +++ apps/gui/gwps.h (working copy) @@ -47,13 +47,11 @@ #define WPS_ALBUMART_CHECK 1 /* WPS contains AA conditional tag */ #define WPS_ALBUMART_LOAD 2 /* WPS contains AA tag */ -#define WPS_ALBUMART_ALIGN_RIGHT WPS_ALIGN_RIGHT /* x align: right */ -#define WPS_ALBUMART_ALIGN_CENTER WPS_ALIGN_CENTER /* x/y align: center */ -#define WPS_ALBUMART_ALIGN_LEFT WPS_ALIGN_LEFT /* x align: left */ -#define WPS_ALBUMART_ALIGN_TOP WPS_ALIGN_RIGHT /* y align: top */ -#define WPS_ALBUMART_ALIGN_BOTTOM WPS_ALIGN_LEFT /* y align: bottom */ -#define WPS_ALBUMART_INCREASE 8 /* increase if smaller */ -#define WPS_ALBUMART_DECREASE 16 /* decrease if larger */ +#define WPS_ALBUMART_ALIGN_RIGHT 1 /* x align: right */ +#define WPS_ALBUMART_ALIGN_CENTER 2 /* x/y align: center */ +#define WPS_ALBUMART_ALIGN_LEFT 4 /* x align: left */ +#define WPS_ALBUMART_ALIGN_TOP 1 /* y align: top */ +#define WPS_ALBUMART_ALIGN_BOTTOM 4 /* y align: bottom */ #endif /* HAVE_ALBUMART */ @@ -379,10 +377,8 @@ struct wps_data unsigned char wps_uses_albumart; /* WPS_ALBUMART_NONE, _CHECK, _LOAD */ short albumart_x; short albumart_y; - unsigned short albumart_xalign; /* WPS_ALBUMART_ALIGN_LEFT, _CENTER, _RIGHT, - + .._INCREASE, + .._DECREASE */ - unsigned short albumart_yalign; /* WPS_ALBUMART_ALIGN_TOP, _CENTER, _BOTTOM, - + .._INCREASE, + .._DECREASE */ + unsigned char albumart_xalign; /* WPS_ALBUMART_ALIGN_LEFT, _CENTER, _RIGHT */ + unsigned char albumart_yalign; /* WPS_ALBUMART_ALIGN_TOP, _CENTER, _BOTTOM */ short albumart_max_width; short albumart_max_height; @@ -508,4 +504,6 @@ void gui_sync_wps_screen_init(void); bool gui_sync_wps_uses_albumart(void); #endif +void bmp_init(void); + #endif Index: apps/buffering.c =================================================================== --- apps/buffering.c (revision 18166) +++ apps/buffering.c (working copy) @@ -50,6 +50,10 @@ #include "pcmbuf.h" #include "buffer.h" #include "bmp.h" +#ifdef HAVE_ALBUMART +#include "albumart.h" +#include "resize.h" +#endif #include "events.h" #include "metadata.h" @@ -843,18 +847,56 @@ static bool fill_buffer(void) Return value is the total size (struct + data). */ static int load_bitmap(int fd) { - int rc; - struct bitmap *bmp = (struct bitmap *)&buffer[buf_widx]; + struct bitmap *aa_bmp, orig_bmp; + int orig_sz, aa_sz, free; /* bytes */ + + orig_sz = get_bmp_size(fd, &orig_bmp); + + if (orig_sz <= 0) + return orig_sz; + + aa_bmp = (struct bitmap *)&buffer[buf_widx]; + free = (int)MIN(buffer_len - BUF_USED, buffer_len - buf_widx) + - sizeof(struct bitmap); + + aa_sz = get_albumart_size(aa_bmp, &orig_bmp); + + if ((aa_sz > free) || aa_sz <= 0) + return 0; + /* FIXME: alignment may be needed for the data buffer. */ - bmp->data = &buffer[buf_widx + sizeof(struct bitmap)]; + aa_bmp->data = &buffer[buf_widx + sizeof(struct bitmap)]; + if (aa_bmp->width == orig_bmp.width && aa_bmp->height == orig_bmp.height) { #if (LCD_DEPTH > 1) || defined(HAVE_REMOTE_LCD) && (LCD_REMOTE_DEPTH > 1) - bmp->maskdata = NULL; + aa_bmp->maskdata = NULL; #endif + aa_sz = read_bmp_fd(fd, aa_bmp, free, FORMAT_ANY|FORMAT_DITHER); + } else { + int ex_free = free - aa_sz; + + if (orig_sz > ex_free) + return 0; + +#if (LCD_DEPTH > 1) || defined(HAVE_REMOTE_LCD) && (LCD_REMOTE_DEPTH > 1) + orig_bmp.maskdata = NULL; +#endif + /* FIXME: alignment may be needed for the data buffer. */ + orig_bmp.data = &buffer[buf_widx + sizeof(struct bitmap) + aa_sz]; + + orig_sz = read_bmp_fd(fd, &orig_bmp, ex_free, FORMAT_ANY|FORMAT_DITHER); + + if (orig_sz <= 0) + return orig_sz; + +#if (LCD_DEPTH > 1) || defined(HAVE_REMOTE_LCD) && (LCD_REMOTE_DEPTH > 1) + aa_bmp->maskdata = orig_bmp.maskdata; + aa_bmp->format = orig_bmp.format; +#endif + resize_bitmap(&orig_bmp, aa_bmp); + } - int free = (int)MIN(buffer_len - BUF_USED, buffer_len - buf_widx); - rc = read_bmp_fd(fd, bmp, free, FORMAT_ANY|FORMAT_DITHER); - return rc + (rc > 0 ? sizeof(struct bitmap) : 0); + return aa_sz + (aa_sz > 0 ? sizeof(struct bitmap) : 0); } #endif