FS#5712 - X5 Backlight Brightness Improvement/Fix

Attached to Project: Rockbox
Opened by Michael Sevakis (MikeS) - Tuesday, 25 July 2006, 05:34 GMT
Task Type Patches
Category LCD
Status Closed
Assigned To No-one
Operating System iAudio X5
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Improves the backlight brightness setting interface/parameters for the iAudio X5.

Parameters held to acceptable ranges per D305A datasheet:
* PWM frequency reduced to 512Hz to keep within 400-2000Hz range (doesn't hurt brightness).
* PWM duty cycle kept within 15%-100% range.

Higher value now equals brighter display by inverting GPO1 on the PMU. This was reversed before.

Improvements to the set_backlight_brightness function.

Default brightness now the same as the boot setting.
This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Tuesday, 25 July 2006, 15:22 GMT
Reason for closing:  Accepted
Comment by Rani Hod (RaeNye) - Tuesday, 25 July 2006, 06:07 GMT
I reviewed it and it seems OK, but I can't test low-level stuff without an actual device.
Gimme one positive user report (except yours) and it's in :)
Comment by Michael Sevakis (MikeS) - Tuesday, 25 July 2006, 06:23 GMT
Should I grovel for one on IRC? hehe :D

I should warn that it would break your LCD flash patch because of the PMU change since LCD OFF is now 0x80 instead of 0x70.

BTW: How'd you test the backlight thing if you don't have a device?
Comment by Michael Sevakis (MikeS) - Tuesday, 25 July 2006, 06:26 GMT
Actually, on second thought, it wouldn't really break it or vice versa. Off is simply off as done in pcf50606-x.c.