Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 104 Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /sites/rockbox.org/flyspray/adodb/adodb.inc.php on line 845 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.user.php on line 111 FS#5720 : improved meta data extraction from SID files

Rockbox

Tasklist

FS#5720 - improved meta data extraction from SID files

Attached to Project: Rockbox
Opened by Robert Kukla (roolku) - Wednesday, 26 July 2006, 00:33 GMT
Task Type Patches
Category ID3 / meta data
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

- strings are now converted to UTF-8 for proper display of umlauts and accented letters
- two more tags are extracted from the file:

* year goes into the year tag (obviously)
* copyright holder goes into the album tag (as most WPS will display that)
   sid_meta.patch (1.6 KiB)
This task depends upon

Closed by  Robert Kukla (roolku)
Wednesday, 28 February 2007, 00:59 GMT
Reason for closing:  Accepted
Comment by Robert Kukla (roolku) - Friday, 10 November 2006, 13:26 GMT
updated to current cvs
   sid_meta.patch (2.1 KiB)
Comment by Daniel Stenberg (bagder) - Friday, 10 November 2006, 13:45 GMT
well, this patch now puts _back_ the blindly-assuming-input-data-is-correct that I just modified in CVS. I don't like that the metadata parser assumes that the metadata will be correct but it should survive invalid formats.
Comment by Robert Kukla (roolku) - Friday, 10 November 2006, 14:35 GMT
fair enough - how about this one?
   sid_meta.patch (1.6 KiB)

Loading...