Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category LCD
  • Assigned To No-one
  • Operating System iAudio X5
  • Severity Medium
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by MikeS - 2006-07-29

FS#5734 - X5 LCD Contrast Bug Fix

Fixes a bug in lcd_set_contrast that sets R_POWER_CONTROL5 to an incorrect value that degrades the display (Vertical lines appear when slowly moving the unit side to side and display is darkened a bit). Also changes the way the contrast option is included to minimize editing for newer ports (add HAVE_LCD_CONTRAST to config*.h a la HAVE_BACKLIGHT_BRIGHTNESS). Doesn’t effect the way other ports using “#if !defined(HAVE_LCD_COLOR)” compile.

Within the day I will add an x5 driver performance and features upgrade that will include these changes (if this isn’t committed before then) because I could not avoid it in a reasonable way and it ~will~ conflict. If this is committed :) ~after~ I post the driver upgrade, I will post an update to it. The smaller bug fix is easier to check out than an entire driver update of course.

Closed by  RaeNye
2006-07-31 19:13
Reason for closing:  Accepted

I’m testing this patch right now.
lcd_set_contrast() is based on the analoguous OF function, so it’s probably a Cowon bug as well.

BTW,
thanks for introducing HAVE_LCD_CONTRAST, I thought of doing a similar thing but got lazy ;-)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing