FS#5734 - X5 LCD Contrast Bug Fix

Attached to Project: Rockbox
Opened by Michael Sevakis (MikeS) - Saturday, 29 July 2006, 06:39 GMT
Task Type Bugs
Category LCD
Status Closed
Assigned To No-one
Operating System iAudio X5
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Fixes a bug in lcd_set_contrast that sets R_POWER_CONTROL5 to an incorrect value that degrades the display (Vertical lines appear when slowly moving the unit side to side and display is darkened a bit). Also changes the way the contrast option is included to minimize editing for newer ports (add HAVE_LCD_CONTRAST to config*.h a la HAVE_BACKLIGHT_BRIGHTNESS). Doesn't effect the way other ports using "#if !defined(HAVE_LCD_COLOR)" compile.

Within the day I will add an x5 driver performance and features upgrade that will include these changes (if this isn't committed before then) because I could not avoid it in a reasonable way and it ~will~ conflict. If this is committed :) ~after~ I post the driver upgrade, I will post an update to it. The smaller bug fix is easier to check out than an entire driver update of course.
This task depends upon

Closed by  Rani Hod (RaeNye)
Monday, 31 July 2006, 19:13 GMT
Reason for closing:  Accepted
Comment by Rani Hod (RaeNye) - Monday, 31 July 2006, 17:34 GMT
I'm testing this patch right now.
lcd_set_contrast() is based on the analoguous OF function, so it's probably a Cowon bug as well.

thanks for introducing HAVE_LCD_CONTRAST, I thought of doing a similar thing but got lazy ;-)