Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Drivers
  • Assigned To No-one
  • Operating System iAudio X5
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by MikeS - 2006-07-30

FS#5740 - X5 LCD Performance / Features Upgrade / Bug Fix

Speeds up the X5 LCD driver functions and implements all remaining APIs except lcd_blit and contains the bug fix found in  FS#5734 . The driver patch will be updated if the said bug fix is committed first.

The bootloader gets smaller versions of the lcd_update_* functions (less unrolling of loops).

x5-lcd-performance-before-and-after.txt show a table of framerates gathered using test_fps with the best of three runs for each data point. Should be self-explanatory.

x5-lcd-perf-and-features-test.patch.zip contains a test plugin to test the lcd functions that were changed/added. It exposes some APIs needed by the plugin. Remove the patch included in the zip before committing.

   x5-lcd-perf-and-features.patc... (24.8 KiB)
   x5-lcd-perf-and-features-test... (2.6 KiB)
   x5-lcd-performance-before-and... (0.4 KiB)
Closed by  linusnielsen
2006-07-31 23:00
Reason for closing:  Fixed
MikeS commented on 2006-07-30 08:11

Here’s an updated version. I removed the call to lcd_update in lcd_roll because I think it is a bad idea to force an update because the developer should decide when to update the display. Had to change the plugin as a result. All subsequent drawing operations are still transformed as they should be.

That’s the only qualm I had so pick the way you like it better.

   x5-lcd-perf-and-features.patc... (25 KiB)
   x5-lcd-perf-and-features-test... (2.6 KiB)
RaeNye commented on 2006-07-31 19:39

please sync, #5734 was commited.

BTW, I previously tried Duff’s device as well but I got no FPS gain since I had to take the code out of IRAM.
It’s nice to see you got better results :)

MikeS commented on 2006-07-31 21:51

Removing the lookup table gave me room to roam!

Here it is resynced with contrast change.

   x5-lcd-perf-and-features.patc... (19.2 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing