• Status Unconfirmed
  • Percent Complete
  • Task Type Patches
  • Category Drivers
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by fml2 - 2006-08-01

FS#5757 - Correctly display short DOS file names in file browser

This is a sequel for  FS#5736 . It correctly displays the OEM-encoded short DOS file names.

Following code pages are supported: cp850 (western Europe), cp852 (central Europe), cp737 (greek), cp866 (cyriliic), cp862 (hebrew).

If you change the default code page (in the settings menu) and there are files that are displayed with the short DOS names, you’d better rebuild the dir cache (if it’s activated) since the UTF8-name of the file changes.

When I compile the modified sources, I get the following warning which I don’t understand:
CC common/unicode.c
common/unicode.c:136: warning: function declaration isn’t a prototype

Could anyone tell me what that means and what the reason is?

Project Manager

This prototype:

static bool load_oem_table()

lacks an argument. In ANSI C you need to write it like this:

static bool load_oem_table(void)

fml2 commented on 2006-08-02 17:29

Thanks Linus! Now everything compiles without warnings. Here is the updated patch (also fixed an error in OEM-encoding when the current code page is UTF-8 and made line shorter than 80 chars.)

fml2 commented on 2006-08-05 22:36

Slightly improved patch. Now only the required OEM area is stored in RAM thus reducing the overall code size. And that's good since this feature is probably rearly used so we shouldn't waste much memory on it.


Available keyboard shortcuts


Task Details

Task Editing