• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category User Interface → Language
  • Assigned To No-one
  • Operating System All players
  • Severity Medium
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Steve Bavin - 2006-08-03
Last edited by Steve Bavin - 2006-08-15

FS#5766 - Fix for various voice-related crashes

The attached patch updates playback.c so that the required buffers for a voice codec are initialised even if no voice file is loaded, if thumbnail clips are in use. Without this, attempting to use .talk clips without a voice file will crash. See bug  FS#5570  for details.

Closed by  Linus Nielsen Feltzing
2006-08-15 18:01
Reason for closing:  Accepted
Steve Bavin commented on 2006-08-03 16:12

Here’s the patch.

Steve Bavin commented on 2006-08-03 17:49

OK, take 2. This will set up the voice codec if a voice file has been loaded or thumbnails are in use.

Steve Bavin commented on 2006-08-03 17:51

I keep forgetting to attach the right patch… here it is.

Steve Bavin commented on 2006-08-03 18:07

Add the following patch to force a call to audio_set_crossfade when the .talk options are changed. This works a bit better, but still can crash. Unfortunately I don’t have time to look further right now.

Steve Bavin commented on 2006-08-15 17:12

Fixed the above problem and it seems to have been caused by the same bug which causes Ogg Vorbis (and maybe other codec) playback crashes. The attached patch supercedes all above attachments.


Available keyboard shortcuts


Task Details

Task Editing