Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Playlists
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by nls - 2006-08-09

FS#5784 - Strip extension from all filetypes in the playlist viewer

This patch replaces the check for a .mp3 .mp2 or .mpa file extension with a simple replace last . with \\0 works on h300 target and sim. I could not add files with unsupported extensions to the playlist so I don’t know how it will react with a filename without dots.

(application/octet-stream)    strip_fileext.diff (0.9 KiB)
Closed by  dionoea
2006-08-10 21:09
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Applied. Thanks

dionoea commented on 2006-08-10 09:55

I’m not sure if it’s currently possible to add files with no ‘.’ character in the playlist. If it is, you should check that q is non NULL before changing *q to 0.

my 2cents

nls commented on 2006-08-10 20:35

I don’t think it is possible to do that, at least I haven’t been able to… but it’s probably better to check one time too many instead of one time too few.
here is an updated patch with the suggested check (replaces the previous patch).

(application/octet-stream)    strip_fileext2.diff (1 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing