Rockbox

Tasklist

FS#5784 - Strip extension from all filetypes in the playlist viewer

Attached to Project: Rockbox
Opened by Nils Wallménius (nls) - Wednesday, 09 August 2006, 16:53 GMT
Task Type Patches
Category Playlists
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch replaces the check for a .mp3 .mp2 or .mpa file extension with a simple replace last . with \\0 works on h300 target and sim. I could not add files with unsupported extensions to the playlist so I don't know how it will react with a filename without dots.
This task depends upon

Closed by  Antoine Cellerier (dionoea)
Thursday, 10 August 2006, 21:09 GMT
Reason for closing:  Accepted
Additional comments about closing:  Applied. Thanks
Comment by Antoine Cellerier (dionoea) - Thursday, 10 August 2006, 09:55 GMT
I'm not sure if it's currently possible to add files with no '.' character in the playlist. If it is, you should check that q is non NULL before changing *q to 0.

my 2cents
Comment by Nils Wallménius (nls) - Thursday, 10 August 2006, 20:35 GMT
I don't think it is possible to do that, at least I haven't been able to... but it's probably better to check one time too many instead of one time too few.
here is an updated patch with the suggested check (replaces the previous patch).

Loading...