Rockbox

  • Status Closed
  • Percent Complete
    0%
  • Task Type Patches
  • Category Infrastructure → Build environment
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by tommeyer - 2006-08-09

FS#5785 - Adding make install for devices

This patch modifies configue and buildzip.pl. Adds an option in configure, where the user can specify a mountpoint for the device, so that “make install” will copy files directly to the device, avoiding the multiple steps of make zip and then unzipping the file to the device.

(application/octet-stream)    patch (4.5 KiB)
Closed by  nicolas_p
2007-02-21 00:50
Reason for closing:  Rejected
Project Manager
bagder commented on 2006-08-09 20:17

I disagree with the way its done in this patch.

The simulator already has a ‘make install’ target and if the “real” builds should have a similar I don’t see any reason whatsoever to modify buildzip.pl. I find it better to keep that as simple as possible and add the extra cruft in the Makefile.

Also, I don’t think the mount point is to be defined in the configure script since for many people the mount point can vary so it better be a variable you set at install time… Like “make DIR=/mnt/iriver install”.

tommeyer commented on 2006-08-09 22:18

Since buildzip.pl is the only thing that knows how to pull all the various pieces together into the .rockbox directory, it seemed like a logical place to put it. After all, it’s basically replacing “zip” with “cp -r”. I suppose that buildzip.pl might be a bad name for something that builds more things than zip, but I went with the simplest change to the existing codebase, rather than refactoring everything.

Regarding your second point, you can already say: make MOUNTPOINT=/mnt/iriver install, since it’s already a variable in the Makefile.

Project Manager
bagder commented on 2006-08-09 22:21

Let me stress my two points since it seems I wasn’t clear enough;

1 - buildzip.pl doesn’t need these changes since you can already accomplish this without changing it

2 - asking for the mount point in the configure is the wrong place to ask for such an information since building has nothing to do with mount points

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing