Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by midgey34 - 2006-08-18

FS#5839 - Use Menu API in Plugins

I went through and adapted some of the plugins to use the standard Rockbox Menu API instead of their own implementation. The plugins changed were Dice, Disktidy, Minesweeper, Star, and Xobox. Some of the plugins also received slight cleanups and/or removed dead code and defines. One thing that could be improved is adding titles in these new menus since I couldn’t figure out the correct way to implement one.

(application/octet-stream)    plugin_menu_api.patch (38.6 KiB)
Closed by  midgey34
2007-03-28 07:41
Reason for closing:  Accepted
midgey34 commented on 2006-10-25 04:59

Updated to CVS and broken into separate patch file

(application/octet-stream)    dice.patch (11.1 KiB)
(application/octet-stream)    disktidy.patch (6.2 KiB)
(application/octet-stream)    minesweeper.patch (4.3 KiB)
(application/octet-stream)    snake.patch (4 KiB)
(application/octet-stream)    star.patch (8.2 KiB)
(application/octet-stream)    xobox.patch (5 KiB)
decayed.cell commented on 2007-01-02 07:18

dice.patch, disktidy.patch, minesweeper.patch, needs updating for 20070201 source. Others seem to work fine

midgey34 commented on 2007-01-05 19:09

I didn’t know there was much of an interest in these patches. Here are updated versions, enjoy.

(application/octet-stream)    dice.patch (11.7 KiB)
(application/octet-stream)    disktidy.patch (8 KiB)
(application/octet-stream)    minesweeper.patch (4.3 KiB)
decayed.cell commented on 2007-01-15 23:36

They need updating for latest SVN again :D coz the Sansa builds have the games now

midgey34 commented on 2007-01-18 01:44

I committed a modified version of the disktidy patch to SVN. Expect more to come soon.

decayed.cell commented on 2007-03-06 11:16

Well its now March, have you had time for any updating?

midgey34 commented on 2007-03-16 06:29

Here’s the newest patches. These versions fix issues with leaking menus and get rid of unnecessary changes. I’ll commit these assuming there are no issues that creep up.

(application/octet-stream)    dice.diff (11.4 KiB)
midgey34 commented on 2007-03-16 06:31

Err, hit the ‘Add Comment’ button a bit too early…

(application/octet-stream)    minesweeper.diff (4.4 KiB)
(application/octet-stream)    snake.diff (3.6 KiB)
(application/octet-stream)    star.diff (14.1 KiB)
(application/octet-stream)    xobox.diff (5.2 KiB)
midgey34 commented on 2007-03-16 21:22

Updated snake to fix a warning.

(application/octet-stream)    snake.2.diff (3.6 KiB)
midgey34 commented on 2007-03-23 19:50

This should be the most up to date version of the patch. It currently uses the old menu API but I haven’t been successful on learning the new version with all the macros. Anyway, this also eliminates a nasty global in Star and provides a work-around so that Star won’t crash on the Gigabeat. The code that was crashing works fine in the sim, so I’m guessing there’s an issue with the LCD driver.

(application/octet-stream)    plugin_menus.diff (41.5 KiB)
jdgordon commented on 2007-03-25 14:33

After much arm twisting in IRC I have commited a converted xobox menu whic is hopefully enough example for you to do the rest “properly” :)

midgey34 commented on 2007-03-26 01:34

Here’s an updated version that uses as much of the new API as possible. It also converts Disktidy to this new API. Let me know if I broke anything or did something incorrectly.

(application/octet-stream)    plugin_menu.2.diff (36.9 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing