Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 104 Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /sites/rockbox.org/flyspray/adodb/adodb.inc.php on line 845 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.user.php on line 111 FS#5845 : Make tagtree.c use buffer_alloc

Rockbox

Tasklist

FS#5845 - Make tagtree.c use buffer_alloc

Attached to Project: Rockbox
Opened by Steve Bavin (pondlife) - Friday, 18 August 2006, 09:03 GMT
Task Type Patches
Category Operating System/Drivers
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

tagtree.c contains a direct modification of audiobuf that can be replaced by a buffer_alloc call.
   tagtreeusebufferalloc.patch (0.8 KiB)
This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Wednesday, 23 August 2006, 08:41 GMT
Reason for closing:  Accepted
Comment by Steve Bavin (pondlife) - Tuesday, 22 August 2006, 10:18 GMT
Now updated to use a single call to buffer_alloc - pre-passes tagnavi.config to count the number of lines in it. Would also fix memory corruption if audiobuf was used during the read process (highly unlikely scenario).
   tagtreealloc2.patch (2.1 KiB)

Loading...