FS#5878 - Follow playlist doesn't work in ID3 view

Attached to Project: Rockbox
Opened by Steve Bavin (pondlife) - Thursday, 24 August 2006, 07:43 GMT
Last edited by Steve Bavin (pondlife) - Thursday, 02 August 2007, 10:20 GMT
Task Type Bugs
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


In ID3 view, pressing stop always returns to the browser with the first file in the current selection selected. If Follow Playlist is enabled, the currently playing file should be selected.

This is probably because the routine set_current_file() in tree.c does not support ID3 view.
This task depends upon

Closed by  Steve Bavin (pondlife)
Thursday, 02 August 2007, 10:20 GMT
Reason for closing:  Rejected
Additional comments about closing:  Might be better to just return to the file browser in this case.
Comment by Dominik Riebeling (bluebrother) - Thursday, 24 August 2006, 08:02 GMT
I don't think it makes sense following the playlist in id3 view -- a file can be accessed in various ways, how do you know which way to use? Having this said I don't consider this behaviour a bug as I can't think of a usefull and consistent way to achieve this.
Comment by Steve Bavin (pondlife) - Friday, 25 August 2006, 09:40 GMT
It would be nice to have consistency across views, after all they are (to the user) just ways of generating a playlist.
Comment by Dominik Riebeling (bluebrother) - Friday, 25 August 2006, 12:38 GMT
sure, it would be nice. But how should this be achieved? It's the same problem as to resume browsing at the same point the device shut down -- in id3 view there are various ways to get to a file. This would even be harder as for saving the last view one could trace the way the user entered the menu while for a "follow playlist" option no information exists in which view the user expects the file to be displayed within.

A possible alternative would be to add a filesystem view entry to the tagcache view (like having tags "filesystem:all, filesystem:supported and filesystem:music) and highlight the file within that filesystem view when follow playlist is enabled.
Comment by Alistair Marshall (amar) - Tuesday, 24 July 2007, 19:21 GMT
Does this 'bug' still apply now that the root menu has been implemented?