FS#5890 - Target tree architecture for iPod 4G Grayscale

Attached to Project: Rockbox
Opened by Ghislain MARY (lunacymaze) - Sunday, 27 August 2006, 08:55 GMT
Last edited by Barry Wardell (barrywardell) - Saturday, 30 September 2006, 00:36 GMT
Task Type Patches
Category Build environment
Status Closed
Assigned To Barry Wardell (barrywardell)
Operating System iPod 4G Grayscale
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Use the target tree architecture to build the iPod 4G Grayscale firmware.

It would be great to do it for the other iPods, and I could do it but I can only test on an iPod 4G Grayscale.
This task depends upon

Closed by  Barry Wardell (barrywardell)
Thursday, 05 October 2006, 14:52 GMT
Reason for closing:  Accepted
Additional comments about closing:  Most recent patch committed to CVS.
Comment by Barry Wardell (barrywardell) - Friday, 29 September 2006, 23:13 GMT
I've expanded greatly upon this patch and moved all iPods to the target tree. All iPod targets build, and I have tested the Color/Photo build on an actual iPod without any noticable problems. Can others please test this on other models?

There is some code duplication, particularly in ipod4g_button_read(), and quite a lot of #ifdef's in the Rockbox code, but this is a start at least.
Comment by Barry Wardell (barrywardell) - Sunday, 01 October 2006, 02:01 GMT
I missed a couple of changes in my last patch. Here's an updated one which should compile OK.
Comment by Barry Wardell (barrywardell) - Sunday, 01 October 2006, 02:35 GMT
Updated again. Moved the common 4g button code into a single file.
Comment by Barry Wardell (barrywardell) - Sunday, 01 October 2006, 16:56 GMT
Looks like I missed a load of files in the last patch. Hopefully this one will work.
Comment by Barry Wardell (barrywardell) - Monday, 02 October 2006, 01:09 GMT
Added DEFAULT_CONTRAST_SETTING for grayscale ipods which was stopping them from compiling.
Comment by Barry Wardell (barrywardell) - Wednesday, 04 October 2006, 14:46 GMT
Updated patch. Renamed apple directory to ipod. Combined all the common backlight and power code into files shared between models. No need for most of the model specific subdirs any more, so remove them.
Comment by Daniel Ankers (dan_a) - Wednesday, 04 October 2006, 18:05 GMT
I can confirm that this patch works with a 3G iPod
Comment by Robert Keevil (obo) - Wednesday, 04 October 2006, 18:32 GMT
And also a 5G.