FS#5893 - Fix quickscreen exit with iriver remotes.
Attached to Project:
Rockbox
Opened by David Rothenberger (drothenberger) - Sunday, 27 August 2006, 19:12 GMT
Opened by David Rothenberger (drothenberger) - Sunday, 27 August 2006, 19:12 GMT
|
DetailsFix quickscreen H1x0/H3x0 remote keymaps.
* Exit on MODE button short press. * Make H1x0 mappings the same as the H3x0 LDC mappings. These mappings seem more consistent with the onscreen graphics. |
This task depends upon
Closed by Dominik Riebeling (bluebrother)
Friday, 01 September 2006, 15:32 GMT
Reason for closing: Fixed
Friday, 01 September 2006, 15:32 GMT
Reason for closing: Fixed
The bitrate/source keys on the H1xx remote have always acted as up/down
Well done for spotting the typo for the H3xx though.
BTW, the typo was also for the H1xx remote.
Before the changes:
REW -> LEFT
FF -> RIGHT
VOLUP -> DOWNINV
VOLDOWN -> DOWN
These are the same as the current H3xx mappings, BTW.
The attached patch
1. Fixes the typo for the H1xx remote, so MODE exits the menu.
2. Restores the pre-keymap mappings.
3. Adds BITRATE and SOURCE as DOWN/DOWNINV mappings.
IMHO, this is much more intuitive. Plus, it is consistent with the old mappings and the current H3xx mappings.
How the hell did that happen?
REW/FF aren't even left/right! I must have been snoozing off when I put those in...
But you definitely shouldnt use the H3xx mappings as anything to go by, The H3xx remote is completely different to the H1xx remote. It's much more like the main unit and so 100 times better IMO.
Was it really volup/down before the action code? how odd...I could have sworn... ahh well never mind, I'll put it all in anyway. Thanks for spotting that.