Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Games
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Dominik Riebeling - 2006-08-29
Last edited by Nils Wallménius - 2006-11-10

FS#5903 - Move doom game files to /.rockbox/doom

Simply as the title says: currently doom looks for its files in /games/doom. IMO the game files shouldn’t be put in a visible folder but as pacbox does somewhere below /.rockbox – configuration and themes are also stored there. The attached patch simply modifies doom to look in /.rockbox/doom for its files.

Closed by  Dominik Riebeling
2007-01-13 15:17
Reason for closing:  Accepted
Additional comments about closing:  

after some discussion the data is now located in /.rockbox/doom

Paul Louden commented on 2006-08-29 18:36

Had I commit access, I would so be all over this. It would solve the question of "I keep clicking on the Doom files and it doesn't do anything." As well as improving consistency.

Jonas Häggqvist commented on 2006-08-29 18:51

Is there any reason this should not be applied? I've been wondering about this ever since Doom appeared first.

Actually, wouldn't it be smarter to have /.rockbox/games/ and then packbox and doom dirs under that?

Paul Louden commented on 2006-08-29 18:53

That could work as well.

The way I see it, any files that are unnecessary (and perhaps unwise) for a user to have direct access to should be hidden under /.rockbox/

A /.rockbox/games folder would be perfectly suitable I think, though people might ask why we don't put the game plugins there so that they're categorized. Maybe /.rockbox/gamedata ?

Jonas Häggqvist commented on 2006-08-29 18:57

Gamedata is probably a better name indeed. But other than that, how could it possibly be a problem, except for the fact that people will need go into a hidden folder to put the files there - I don't know how much of a problem that is?

Paul Louden commented on 2006-08-29 18:59

The folder isn't hidden on a Windows PC at least. On other operating systems, it's still possible to find it, and most Linux users wouldn't have a problem doing so. I think it's a good idea.

Jonas Häggqvist commented on 2006-08-29 19:06

It will of course break the game for anyone who has it installed into /games/doom/ right now - what's the error it emits if no files are found? It should probably say something like "no files found in .rockbox/games/doom" so people can see what's going wrong (if they bother to read the error message of course).

Other than that, i say go for it.

Steve Bavin commented on 2006-08-29 20:28

Why not look in /.rockbox/doom (or wherever) first, then fall back to looking in /games/doom, then fall back to giving an error which refers to .rockbox/doom?

Dominik Riebeling commented on 2006-08-29 20:46

having a fallback location might cause additional confusion if the user sometimes has installed files into /.rockbox/doom and later places additional files in /games/doom causing "doom doesn't find my files" problems. Also, implementing a fallback method would need a tiny bit more work (not that it matters, but anyhow …)

When moving the game files to /.rockbox/gamedata/doom/ we should also consider moving the pacbox data to /.rockbox/gamedata/pacbox/.

Jonas Häggqvist commented on 2006-08-29 20:55

This patch moves Doom data to /.rockbox/gamedata/doom/ and pacbox data to /.rockbox/gamedata/pacbox/

Jonas Häggqvist commented on 2006-08-29 20:56

I'll try that again..

Dominik Riebeling commented on 2006-08-29 21:22

Jonas, with your patch I get the following warnings:

rockdoom.c:211: warning: initializer-string for array of chars is too long
rockdoom.c:211: warning: (near initialization for ‘wads_builtin[0]’)

The attached modified version fixes this. Also used ROCKBOX_DIR for the pacbox path. So far I only tested doom on the h120 sim, I need to get the pacbox roms before I can test the modified pacbox.

Jonas Häggqvist commented on 2006-08-29 21:36

That was a stupid mistake of me. I just tested pacbox in the sim with your patch. Works nicely.

Admin
Daniel Stenberg commented on 2007-01-08 11:41

I'm in favour of this move as well

Paul Louden commented on 2007-01-08 11:44

I'm in favour of this AND including rockdoom.wad in the download. It's 280kb, uncompressed, so it won't hurt the download size too much (in my opinion) and we can change the splash to "No IWAD in /.rockbox/doom" to be a bit more explicit about what is needed, as the Base Wads one is somewhat vague anyway.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing