Rockbox

Had I commit access, I would so be all over this. It would solve the question of "I keep clicking on the Doom files and it doesn't do anything." As well as improving consistency.

Is there any reason this should not be applied? I've been wondering about this ever since Doom appeared first.

Actually, wouldn't it be smarter to have /.rockbox/games/ and then packbox and doom dirs under that?

That could work as well.

The way I see it, any files that are unnecessary (and perhaps unwise) for a user to have direct access to should be hidden under /.rockbox/

A /.rockbox/games folder would be perfectly suitable I think, though people might ask why we don't put the game plugins there so that they're categorized. Maybe /.rockbox/gamedata ?

Gamedata is probably a better name indeed. But other than that, how could it possibly be a problem, except for the fact that people will need go into a hidden folder to put the files there - I don't know how much of a problem that is?

The folder isn't hidden on a Windows PC at least. On other operating systems, it's still possible to find it, and most Linux users wouldn't have a problem doing so. I think it's a good idea.

It will of course break the game for anyone who has it installed into /games/doom/ right now - what's the error it emits if no files are found? It should probably say something like "no files found in .rockbox/games/doom" so people can see what's going wrong (if they bother to read the error message of course).

Other than that, i say go for it.

Why not look in /.rockbox/doom (or wherever) first, then fall back to looking in /games/doom, then fall back to giving an error which refers to .rockbox/doom?

having a fallback location might cause additional confusion if the user sometimes has installed files into /.rockbox/doom and later places additional files in /games/doom causing "doom doesn't find my files" problems. Also, implementing a fallback method would need a tiny bit more work (not that it matters, but anyhow …)

When moving the game files to /.rockbox/gamedata/doom/ we should also consider moving the pacbox data to /.rockbox/gamedata/pacbox/.

This patch moves Doom data to /.rockbox/gamedata/doom/ and pacbox data to /.rockbox/gamedata/pacbox/

I'll try that again..

   games_data_move.diff (2.3 KiB)

Jonas, with your patch I get the following warnings:

rockdoom.c:211: warning: initializer-string for array of chars is too long
rockdoom.c:211: warning: (near initialization for ‘wads_builtin[0]’)

The attached modified version fixes this. Also used ROCKBOX_DIR for the pacbox path. So far I only tested doom on the h120 sim, I need to get the pacbox roms before I can test the modified pacbox.

   games_data_move2.diff (2.9 KiB)

That was a stupid mistake of me. I just tested pacbox in the sim with your patch. Works nicely.

I'm in favour of this move as well

I'm in favour of this AND including rockdoom.wad in the download. It's 280kb, uncompressed, so it won't hurt the download size too much (in my opinion) and we can change the splash to "No IWAD in /.rockbox/doom" to be a bit more explicit about what is needed, as the Base Wads one is somewhat vague anyway.