FS#5937 - Missing info / screen corruption on H1x0 RWPS using iAmp theme
Attached to Project:
Rockbox
Opened by Rich Benstead (emorockernerd) - Monday, 04 September 2006, 22:32 GMT
Last edited by Marianne Arnold (pixelma) - Wednesday, 19 December 2007, 09:04 GMT
Opened by Rich Benstead (emorockernerd) - Monday, 04 September 2006, 22:32 GMT
Last edited by Marianne Arnold (pixelma) - Wednesday, 19 December 2007, 09:04 GMT
|
DetailsThere appears to be missing info on H1x0 RWPS using the iAmp theme. I am using a H140. The RWPS is fine using CVS build from 24/08/2006 but something seems to have happened since that date. I suspect it could be do to with the driver for the LCD remote as the pixels bottom right of the screen appear to flicker and not display text. Normally the count of songs in the playlist/folder appears here. I am happy to test if someone attempts to fix this. Rich :)
|
This task depends upon
Closed by Marianne Arnold (pixelma)
Wednesday, 19 December 2007, 09:04 GMT
Reason for closing: Fixed
Additional comments about closing: Closing it now because: judged from the sim it seems fixed and I got no negative answer - if not, feel free to request a reopen. If you want your new version to be looked at, better file a new patch.
Wednesday, 19 December 2007, 09:04 GMT
Reason for closing: Fixed
Additional comments about closing: Closing it now because: judged from the sim it seems fixed and I got no negative answer - if not, feel free to request a reopen. If you want your new version to be looked at, better file a new patch.
I can not confirm any flicker. On my Iriver H100 it just displays the icon for the filetype and the other time it is blank, or shows one ".". I assume this is the decimal point for the bitrate.
While looking at it I could see:
nothing, then the filetype bitmap, then the already mentioned dot - changing each 3 seconds like in the subline definition.
My impression is that the textual info (playlist position/playlist entry in the first subline - bitrate info in the third subline) is hidden by an empty solid rectangle in place of the filetype bitmap that is part of the second subline.
I looked through the list of commits ("since 1st August" on the front page) what changed between August 24th and September 5th and found the last commit to gwps-common.c by Magnus Holmgren (Lear/learman) on Aug 29th, that could have an influence on that behaviour. To prove this theory I checked out revision 10792 (the one right before) - compiled a sim and tested iAmp and it worked as expected; then I "updated" to revision 10793 - tested it again and iAmp remote wps was broken. Hope it helps someone knowledgeable of the code to fix it.
(Btw. one of you who noticed early enough that it was a change during this time that caused it, could have tested with daily builds to narrow the period down to one day - as long as they were part of the last 30 dailies which are available.)
Actually, the "empty solid rectangle" is the place where the following preloaded bitmaps, "Pause", "Fast Forward" and "Rewind" would load to if the user either paused, fast forwarded or rewinded a track.
If you remove the code for those preloaded images and the Playback mode tag, you should see more of the textual info on the rotating lines.
However, the "codec" images also cover the textual info (playlist position, etc.).
Hopefully a developer/programmer can address this issue, as it is one of the reasons why I did not release a new version of iAmp since late 2005.
Thanks for narrowing down the time frame as to when this bug occurred, Marianne!
and there seems to be changes to these lines:
on line 1382 (revision 10792):
skip_conditional(NULL, fmt, 0, &intval);
has changed to the following on the new revisions (currently on line 1406):
skip_conditional(gwps, fmt, 0, &intval);
also on line 1396 (revision 10792):
fmt = skip_conditional(gwps, fmt, 1000, NULL);
has changed to the following on the new revisions (currently on line 1420):
fmt = skip_conditional(NULL, fmt, 1000, NULL);
and lastly on line 1399 (revision 10792):
fmt = skip_conditional(gwps, fmt, intval - 1, NULL);
has changed to the following on the new revisions (currently on line 1423):
fmt = skip_conditional(NULL, fmt, intval - 1, NULL);
if these values were reverted to those from revision 10792, would that fix the remote bitmap issue?
http://svn.rockbox.org/viewvc.cgi/trunk/apps/gui/gwps-common.c?view=diff&r1=10792&r2=10793
this shows you the exact differences!
sorry for the additional comment! first time using SVN!
I don't update very often but am happy to assist anyone who is able to look into this. I can test and provide feedback.
a public update will be made once i have made all the new codec images... been too lazy to make them! :p
If you want another tester before you release the final version let me know.
The "empty solid rectangle" must be some kind of remainder (or place holder) of the images which were there but are subsequently hidden. This obviousy wasn't a problem when iAmp was originally developed and must have been introduced in a later Rockbox build. Is it a bug or a feature?
Was this done on the latest build of Rockbox?
Sorry about the delay for iAmp 2.0, i must say i'm getting lazy as the days go by!
I've been using an old build from late March when i was doing my testing before.
So I guess I need to test it out on the new dailies as well!
I'm a little hesistant to do so, but that brand-new WMA support looks really tempting! :)
Will try and get iAmp "deux" up by the end of the weekend... if not, then the week after!
Hope you can wait a little longer!
iAmp (deux!) released!
:)
I modded iAmp 1.0 myself to include a few extra details (like play count) and changed the volume display to numeric.
Thanks for the credit in your readme.txt :)
Are you sure you want to close the task? It is still a bug / issue, the difference is we can work around it now! I guess it'll be even lower priority to fix if it remains open and it's been open almost year already!
Sorry for the slow response, for some reason no email notifications of new posts were coming through?!
Good to hear you have modified iAmp to your liking! As for the emails, maybe SVN just doesn't like me!
The reason why I didn't add the numerical volume in the RWPS was because of the font being too large; if Rockbox ever supports dual fonts, this would be changed! As for play count, I do not use Rockbox's database feature! ;)
Forgot to mention in the readme that the RWPS now includes a virtual disk LED. So if Rockbox is accessing the hard drive, you can now tell!
About closing the task, it could be that I previously exploited a function of Rockbox before, so it might well be that iAmp is the one that is causing the problems and not the other way around... In the end, it is up to the devs if they want to close it or not.
And btw, no need to thank me for the credit! ;)
I would suggest to close this bug report and if you still want to submit a new version, then file it as a patch. If there are no objections or comments in the next days, I'll close it.