Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Recording
  • Assigned To No-one
  • Operating System All players
  • Severity Medium
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by ahellmann - 2006-09-11

FS#5972 - DivideByZero fix with recordings

This patch solves the DivideByZero problem (I05 at 0x31020634) at recording start/end on iriver. In read_peak_levels() were 2 uncontrolled divisions with variable values. This patch fixes http://www.rockbox.org/tracker/task/5961.

   recording.patch (1 KiB)
Closed by  mmmm-
2006-09-13 18:22
Reason for closing:  Fixed
learman commented on 2006-09-12 17:31

Shouldn't something still be written to balance_mem?

ahellmann commented on 2006-09-12 20:47

At least for me the first priority is the stability of the player.
This I05-error was very annoying.
Secondly the zeros should be very rare at least in recording mode.
So to my understanding of the code there is no disadvantage with this patch.
But I am happy, if the AGC responsible programmer can solve the problem
in a more elaborated way.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing