• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by fml2 - 2006-09-14
Last edited by jdgordon - 2007-08-01

FS#5994 - Mark current font/wps when viewing all (resolution for FS#5080)

Position cursor to the current setting when browsing fonts, wps, rwps, eq preset, fmr. This can’t be done for themes since the current theme is not saved in the settings.

Closed by  jdgordon
2007-08-01 14:16
Reason for closing:  Rejected
fml2 commented on 2006-09-15 20:20

Updated the patch:
- introduced constants for standard file extensions
- replaced strcpy+strcat with snprintf (it’s safer) – thanks Linus for the tip
- moved some constants into format string (they are not printed with %s anymore)

The one who will (hopefully) commit this patch: please adjust the definition of FONT_DIR, LANG_DIR, and CODECS_DIR in settings.h so that it contains ROCKBOX_DIR (like e.g. WPS_DIR). Places where these constants are used should be also adjusted.

Linus, my patch doesn’t break the ‘Follow playlist’ feature – testes with the sim and on target (iriver H1xx).

I was thinking that maybe after jdgordon commits the new settings menu patch, it’d be better to have this done in a similar way (i.e., have a little arrow pointing to the current setting as well as beginning on it).


Available keyboard shortcuts


Task Details

Task Editing