Rockbox

Tasklist

FS#6012 - Accepting with On doesn't work in Time & Date screen.

Attached to Project: Rockbox
Opened by Nils Wallménius (nls) - Sunday, 17 September 2006, 15:40 GMT
Task Type Bugs
Category Configuration
Status Closed
Assigned To Jonathan Gordon (jdgordon)
Operating System Iriver H300 series
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

On the "Time & Date" screen the text at the bottom states "ON To Set" "OFF To Revert" but both on (play) and off on the h300 cancels out of the screen without changing the time or date. Pressing the NAVI button does however work. But canceling with play doesn't feel right. I commented out line 150 in keymap-h1x0_h3x0.c
{ ACTION_SETTINGS_RESET, BUTTON_ON, BUTTON_NONE },
and that seems to fix it.
I also did a search for ACTION_SETTINGS_RESET in the source and the only files that contain it are the keymaps for h100/h300, h10 and gigabeat and the action.h file. So it seems it isn't used anywhere.
This task depends upon

Closed by  Nils Wallménius (nls)
Tuesday, 19 September 2006, 16:20 GMT
Reason for closing:  Fixed
Additional comments about closing:  You are right i deleted my local copy and made afresh checkout and it works :-)
It still seems the action (ACTION_SETTINGS_RESET) is unused.
Comment by Jonathan Gordon (jdgordon) - Tuesday, 19 September 2006, 00:58 GMT
it looks like you are using an old version...
const struct button_mapping button_context_time[] = {
{ ACTION_STD_CANCEL, BUTTON_OFF, BUTTON_NONE },
{ ACTION_STD_OK, BUTTON_ON, BUTTON_NONE },
LAST_ITEM_IN_LIST__NEXTLIST(CONTEXT_SETTINGS),
};
is what the cvs keymap-h1x0-h3x0.c file looks like for the time screen.

Loading...