Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Configuration
  • Assigned To
    jdgordon
  • Operating System Iriver H300 series
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by nls - 2006-09-17

FS#6012 - Accepting with On doesn't work in Time & Date screen.

On the “Time & Date” screen the text at the bottom states “ON To Set” “OFF To Revert” but both on (play) and off on the h300 cancels out of the screen without changing the time or date. Pressing the NAVI button does however work. But canceling with play doesn’t feel right. I commented out line 150 in keymap-h1x0_h3x0.c
{ ACTION_SETTINGS_RESET, BUTTON_ON, BUTTON_NONE },
and that seems to fix it.
I also did a search for ACTION_SETTINGS_RESET in the source and the only files that contain it are the keymaps for h100/h300, h10 and gigabeat and the action.h file. So it seems it isn’t used anywhere.

Closed by  nls
2006-09-19 16:20
Reason for closing:  Fixed
Additional comments about closing:  

You are right i deleted my local copy and made afresh checkout and it works :-) It still seems the action (ACTION_SETTINGS_RESET) is unused.

it looks like you are using an old version… const struct button_mapping button_context_time[] = {

  { ACTION_STD_CANCEL,       BUTTON_OFF,  BUTTON_NONE },
  { ACTION_STD_OK,           BUTTON_ON,   BUTTON_NONE },
  LAST_ITEM_IN_LIST__NEXTLIST(CONTEXT_SETTINGS),

};
is what the cvs keymap-h1x0-h3x0.c file looks like for the time screen.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing