Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Music playback
  • Assigned To No-one
  • Operating System Archos Player
  • Severity Very Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by MHen - 2006-09-24

FS#6052 - more responsive skip

This path improved the responsiveness of the skip commands while the buffer is filled with data. In particular, it allows you to skip during the first seconds of a song playing.

This is achieved by simply removing all pending MPEG_NEED_DATA from the mpeg_queue when inserting a skip there. Thus preventing the skip to be delayed by the loading of no-more-needed data.

(application/octet-stream)    responsive_skip.diff (2.1 KiB)
Closed by  linusnielsen
2006-10-19 11:43
Reason for closing:  Accepted
Project Manager
linusnielsen commented on 2006-09-25 11:35

Looks nice and simple. I think we could commit it right away.

I think I’d like the function to be called queue_remove_from_head().

MHen commented on 2006-09-25 20:40

I am very happy, you like this patch. I attach is the same patch with the function renamed.

(application/octet-stream)    responsive_skip_2.diff (2 KiB)
ryran commented on 2006-09-25 21:32

Sweet.

Project Manager
linusnielsen commented on 2006-10-19 08:03

Oooops, looks like I forgot about this one. Can I have your real name for the credits?

MHen commented on 2006-10-19 10:20

Yes, after a while I was a bit confused, what to do next.

Of course you can have my real name.
http://resized.file.sc/anon/db6w7EH5.png

Project Manager
linusnielsen commented on 2006-10-19 10:22

You do realize that I will put your name in the CREDITS file?

MHen commented on 2006-10-19 11:33

Yes, I know that. I read that even before I started programming Rockbox (at http://www.rockbox.org/docs/contributing.html) and it’s fine with me.

To explain my attitue in a few sentences: It’s okay that anyone who reads something I wrote knows my name. But I want to avoid that anyone knowing my name can easily get a list of all things I wrote. Not because I have anything to hide, but because I do not have any control about that data. Who knows what a future employer will find in 30 years time, when he searches the Internet for my name.

But I’m not fanatic about that. The only sensible format of a credits file is plain text. To have my name in there is okay with me.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing