Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by mikeage - 2006-09-28
Last edited by jdgordon - 2007-08-04

FS#6082 - Switch order of playlist / sound settings in WPS Context

This patch will reverse the order of the playlist/playlsit catalog and sound settings menu items in the WPS Context Menu.

With this patch, to view the current playlist from the WPS, simply:

Hold select
Select
Select

Instead of

Hold select
Down
Select
Select.

See http://forums.rockbox.org/index.php?topic=6736.0

   wps_context_order.patch (0.9 KiB)
Closed by  jdgordon
2007-08-04 14:42
Reason for closing:  Rejected
afruff23 commented on 2006-10-12 04:42

This is much needed. The “view current playlist” menu item is too nested in the menus.

mikeage commented on 2006-10-12 04:45

It’s still nested, but since it’s only one unique button away, I think it’s easier.

ryran commented on 2006-10-18 09:15

thank you thank you thank you. I really appreciate this patch. :)

(so obviously there’s my vote for a commit.)

pondlife commented on 2006-10-30 16:57

I vote for a commit too.

ace214 commented on 2007-02-05 02:27

does this still actually work?

mikeage commented on 2007-02-05 02:33

Of course it does :)

It’d be hard to _break_ a patch this simple and stupid…

ace214 commented on 2007-02-05 02:34

when i applied it just now, it patched but didnt function on the device

mikeage commented on 2007-02-05 02:56

Hrmm.

I just checked svn diff against the latest version.. the patch looks the same, although the line numbers changed. Perhaps since there’s relatively little context, it’s not applying it in the right place.

Try the attached.

   playlist_order.patch (0.8 KiB)
ace214 commented on 2007-02-05 03:12

nope. didn’t work.

mikeage commented on 2007-02-05 03:19

Weird. Works for me on my ipod 4g gray… builds are available at mikeage.net/content/rockbox-custom-builds/

Do you see _any_ change at all?

When you press and hold select from the WPS, what menu items do you have?

ace214 commented on 2007-02-05 03:30

OK, sorry. I was an idiot…. -_-

mikeage commented on 2007-02-05 03:38

NP :)

ryran commented on 2007-02-05 03:46

nice. thanks for updating it Mike. :)

ryran commented on 2007-02-12 20:56

a simple synch

   playlist_order.patch (0.8 KiB)
ryran commented on 2007-04-02 20:02

sync to svn13005

   playlist-13005.patch (0.8 KiB)
ryran commented on 2007-04-30 20:03

ridiculously easy to do now with the new menu system… but sure.. why not.

   playlist-13295.patch (0.5 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing