Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Recording
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by linuxstb - 2006-09-30
Last edited by jdgordon - 2007-08-05

FS#6096 - Recording for ipod 4g/Photo/5g and iriver H10

Attached is a work-in-progress patch to implement recording on the ipods.

I first implemented this a couple of months ago, and have now resynced it to CVS following the major reworking of the Rockbox recording code. I have only tested the resynced version of the patch on a 5g, but it should also be working on the 4g (greyscale) and Photo/Color.

On the 5g, recording is via the line-in pins hidden in the dock connector. On the 4g/Photo, recording is either via the line-in pins, or via the the right channel in the headphone socket which doubles as a mic input.

Remaining issues/unimplemented features:

1) Playback is broken after recording
2) No gain control
3) mp3 codec is untested, wavpack codec doesn’t work. WAV is OK.
4) Only 16-bit/44.1KHz is implemented - the recording hardware should be able to handle a variety of samplerates up to 24-bit/96KHz.

(application/octet-stream)    ipodrecordv1.diff (28.6 KiB)
Closed by  jdgordon
2007-08-05 10:38
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

seems this was commited a while ago

barrywardell commented on 2006-10-02 00:53

Updated patch adds support for the WM8731 and hence the iriver H10. Disable recording isn’t implemented yet, so it is necessary to restart Rockbox after recording in order to playback again.

(application/octet-stream)    ipodrecordv2.diff (37.6 KiB)
barrywardell commented on 2006-10-06 09:57

Updated with wmcodec_disable_recording() implemented for the WM8731. The 4 remaining issues are still present.
Now that the scope of this bug is greater than just the ipods, should the title/details be changed, or should we start a new bug report?

(application/octet-stream)    pp_record.diff (38.4 KiB)
linuxstb commented on 2006-10-06 11:59

I’ve changed the title to add the H10.

bot47 commented on 2006-10-09 08:12

I know that that nano 1st gen and the 5G 1st gen are nearly the same machines. Do recording work on nanos too?

linuxstb commented on 2006-10-09 15:34

As far as I know, the 1st Gen Nano can’t record - it contains a WM8795G audio codec, compared to the WM8975 in the 4g and Photo/Color. My understanding is that the “G” suffix means it only has a DAC, and not an ADC.

bot47 commented on 2006-10-11 07:47

That’s quite strange as the 1st gen nano also got an “Line In”-entry in its debugging menu…

innersoul commented on 2006-11-10 10:37

Hi Barry,

tested your compiled version on a H10 6GB (Link: http://barrywardell.net/assets/files/rockbox-recording-6gb.zip)
Could only test Mic-In so far, but with WAV as codec selected, it worked flawlessly! Thanks!
Any news on other codecs? Maybe a newer compiled version? Or is this patch rather simple to apply it yourself?

cheers,

innersoul

stanelie commented on 2006-11-10 14:21

Hi Barry.

I just tried recording through the line in and it does not work. It works through the mic in though.

Stan

innersoul commented on 2006-11-10 14:47

I have to correct myself: The version downloadable from the address I gave reads from the 31.10.2006 - so apparently it is already a newer compiled version…

innersoul commented on 2006-11-10 19:14

Hello, tried again with H10 6GB and the cradle: Couldn’t get a signal at line-in unfortunately… Would it help to send you the I/O ports from the debug menu?

cheers

barrywardell commented on 2006-12-17 21:40

Updated to CVS. All encoding types now work. Still no gain control, playback after recording or sample rate control. Not tested with H10 line-in.
I will clean this up a little then commit it if there are no problems reported.

(application/octet-stream)    pp_record_v2.diff (54.8 KiB)
stanelie commented on 2006-12-18 04:03

I synched with today’s cvs and tried applying the patch. Patch says that the patch is already applied (patch -p0 < pp_record_v2.diff). Line in is not working.

innersoul commented on 2006-12-18 07:15

@stanelie
that’s because IT IS already in CVS! read what Barry says, you don’t need to apply this patch…

stanelie commented on 2006-12-18 14:36

Sorry about that.

Still no line in.

S.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing