- Status Closed
- Percent Complete
- Task Type Patches
- Category Music playback
-
Assigned To
pondlife - Operating System All players
- Severity Low
- Priority Very Low
- Reported Version
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#6119 - Simplify playback to fix rebuffering problems
For safety’s sake, I’ll upload patches for my latest playback.c tinkering - this is aiming to resolve FS#6117 and FS#5906 .
First one - adds track indexes to the audio thread debug screen, ensures that filebufused can’t wrap below 0 and removes a test based on audio_track_count() which seems unnecessary.
THIS IS NOT READY TO BE COMMITTED YET! But feel free to test or comment - especially if you’re having the problem.
(Edit - removed out of date patch)
Closed by pondlife
2006-10-17 06:14
Reason for closing: Out of Date
Additional comments about closing:
2006-10-17 06:14
Reason for closing: Out of Date
Additional comments about closing:
Superceded by #6199
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
OK, here’s an all new playback.c. This scraps some unneeded variables:
- buf_ridx (calculated from ci.curpos)
- filebufused (calculated from ci.curpos)
- cur_ti (aliased based on track_ridx)
This resolves http://www.rockbox.org/tracker/task/5906.
It also introduces the following known problems (to be worked out):
- Rewinding into a non-buffered section results in a quick burst of the wrong track (or maybe noise) being played.
- The existing problem where the WPS doesn’t update in the last few seconds (during PCM flush) appears to be worse.
- The reported song position sometimes exceeds the song length at the end of a track (rounding?)
Please test and report back, and I’ll carry on whenever I get time.
Three more known problems:
- Rebuffering can cause the current track to be skipped, playback moves to next track for no apparent reason.
- Pressing stop, then play misses a bit and results in the WPS display position and playback position being out of sync.
- Resuming after power off/on often starts the track from 0:00, rather than midway through.
It’s not shaping up too well, is it? ;-(
- The reported song position sometimes exceeds the song length at the end of a track (rounding?)
This problem is in the CVS too at least for MP3s. In addition Rockbox “corrects” the displayed song position to the track length when the last second (approximately) is played.