- Status Closed
- Percent Complete
- Task Type Bugs
- Category ID3 / meta data
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#6155 - "oneof" oeprator limited to a list of 3 or less values
In tagnavi_custom.config, I add this line:
“Electronica Artists” → artist ? genre @ “Ambient|Big Beat|Breakbeat|Breaks|Electronic|House|IDM|Psychedelic|Rave|Techno|Trance|Electronica|Synthpop” → album → title = “%02d. %s” tracknum title
The “@” is the new oneof operator. This does not work, but this line does:
“A” → artist ? genre @ “Progressive Rock|Trance|House” → album → title = “%02d. %s” tracknum title
Judging by the “oneof” patch (http://www.rockbox.org/tracker/task/6137) and trial and error, the @ operator does not work with lists with more than 3 values. Could somebody possibly remove this limit or allow the user to set it?
Closed by miipekk
2006-10-10 10:30
Reason for closing: Fixed
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2006-10-10 10:30
Reason for closing: Fixed
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Increased max length to 128.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
The first line of code is oen line with no breaks and now word wrap in the actual tagnavi_custom.config file.
Well, there is no intentional limit in the number of values, but I can confirm the problem. The function seems to return true in all cases for long lists. Which is odd, as it doesn’t do it in my testbed outside rockbox. I suspect a buffer overflow and will investigate further…..
Okay, there is a limit of 32 bytes in the clause string.
Your example has 107 characters. Not sure if it is justifyable to increase the limit and by how much. I have included a patch that changes it to 128 bytes.
How about let the user choose in the menu? ;)