- Status Closed
- Percent Complete
- Task Type Patches
- Category ID3 / meta data
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#6216 - Update so MP3 files are only opened once
Currently MP3 files are opened twice when played - once for playback and seperately for ID3 parsing.
This small patch adds an interface so the playback file handle can be used for ID3 parsing too.
Closed by miipekk
2006-10-25 16:58
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2006-10-25 16:58
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Committed with the corrections.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Here’s a slightly updated version - this reverses the return from get_mp3_metadata to bring it into line with other formats (true=success, false=error).
Looks good, but the check in the new function if file open failed must be: if (fd < 0) … not if (fd == -1). Probably it should return also false.
OK, will update the test. mp3info() actually returns true to indicate an error, so I think that bit is correct.
You don’t think that there’s a potential problem with the same file seek position being used for both metadata and playback buffering? I assume not, or this would be a problem for other formats…