Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category ID3 / meta data
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by pondlife - 2006-10-20

FS#6216 - Update so MP3 files are only opened once

Currently MP3 files are opened twice when played - once for playback and seperately for ID3 parsing.
This small patch adds an interface so the playback file handle can be used for ID3 parsing too.

Closed by  miipekk
2006-10-25 16:58
Reason for closing:  Accepted
Additional comments about closing:  

Committed with the corrections.

Here’s a slightly updated version - this reverses the return from get_mp3_metadata to bring it into line with other formats (true=success, false=error).

Looks good, but the check in the new function if file open failed must be: if (fd < 0) … not if (fd == -1). Probably it should return also false.

OK, will update the test. mp3info() actually returns true to indicate an error, so I think that bit is correct.

You don’t think that there’s a potential problem with the same file seek position being used for both metadata and playback buffering? I assume not, or this would be a problem for other formats…

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing