Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 104 Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /sites/rockbox.org/flyspray/adodb/adodb.inc.php on line 845 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.user.php on line 111 FS#6241 : Tidy up after recent voice shutup fix

Rockbox

Tasklist

FS#6241 - Tidy up after recent voice shutup fix

Attached to Project: Rockbox
Opened by Steve Bavin (pondlife) - Wednesday, 25 October 2006, 07:23 GMT
Task Type Patches
Category Music playback
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Just a minor bit of restructuring to tidy up the code that clears queued/buffered voice data. I'm putting the patch up here so it can be tested on an Archos.
This task depends upon

Closed by  Steve Bavin (pondlife)
Wednesday, 25 October 2006, 08:54 GMT
Reason for closing:  Accepted
Comment by Steve Bavin (pondlife) - Wednesday, 25 October 2006, 07:39 GMT
And here's the patch - it seems to work on SWCODEC, but I'm wary because it removes an mp3_play_stop() which might affect Archos. The removed call was in the wrong place and commented with a fixme anyway...
(application/octet-stream)    voice_shutup_tidyup.patch (5.7 KiB)
Comment by Steve Bavin (pondlife) - Wednesday, 25 October 2006, 08:47 GMT
The previous one seemed to cause MAS to be less talkative than before. Here's a slightly less keen version.
(application/octet-stream)    voice_shutup_tidyup.patch (2.2 KiB)

Loading...