Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Music playback
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by pondlife - 2006-10-25

FS#6241 - Tidy up after recent voice shutup fix

Just a minor bit of restructuring to tidy up the code that clears queued/buffered voice data. I’m putting the patch up here so it can be tested on an Archos.

Closed by  pondlife
2006-10-25 08:54
Reason for closing:  Accepted
pondlife commented on 2006-10-25 07:39

And here’s the patch - it seems to work on SWCODEC, but I’m wary because it removes an mp3_play_stop() which might affect Archos. The removed call was in the wrong place and commented with a fixme anyway…

(application/octet-stream)    voice_shutup_tidyup.patch (5.7 KiB)
pondlife commented on 2006-10-25 08:47

The previous one seemed to cause MAS to be less talkative than before. Here’s a slightly less keen version.

(application/octet-stream)    voice_shutup_tidyup.patch (2.2 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing