Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Music playback
  • Assigned To No-one
  • Operating System SW-codec
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by pondlife - 2006-10-31
Last edited by pondlife - 2007-07-31

FS#6266 - Flush buffered audio if user skips during pause

If the user skips to a new track while playback is paused, upon resuming a little bit of the previous track is played. This patch detects this scenario and flushes the old data before resuming playback.

(application/octet-stream)    flush_on_skip_during_pause.pa... (1.7 KiB)
Closed by  pondlife
2007-07-31 07:58
Reason for closing:  Accepted
pondlife commented on 2006-11-01 08:05

Note this patch could be simplified quite a bit, but would break the sim until  FS#6267  is fixed. Hence the need for another global variable :(

pondlife commented on 2007-07-30 11:30

Sync to SVN - please test and report back!

   flush_on_skip_during_pause-07... (1.6 KiB)
petur commented on 2007-07-30 22:19

Just tested this on h300 and works as advertised… feel free to commit ;)

Soul-Slayer commented on 2007-07-31 02:22

Confirmed on Gigabeat and H10. I think it’s commitable :p

Project Manager
linusnielsen commented on 2007-07-31 04:42

Question: what would be the effect if we always flushed when resuming?

Project Manager
linusnielsen commented on 2007-07-31 04:50

Hmmm, maybe I should have had a better look at the patch before asking. It would of course break the crossfading. I was thinking that we shouldn’t need to detect this scenario as a special case.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing