Notice: A non well formed numeric value encountered in /sites/ on line 96 Notice: A non well formed numeric value encountered in /sites/ on line 96 Notice: A non well formed numeric value encountered in /sites/ on line 96 Deprecated: Function create_function() is deprecated in /sites/ on line 104 Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /sites/ on line 845 Deprecated: Function create_function() is deprecated in /sites/ on line 111 FS#6293 : Repeat shuffle does not shuffle



FS#6293 - Repeat shuffle does not shuffle

Attached to Project: Rockbox
Opened by Dan (Skyly) - Sunday, 05 November 2006, 17:30 GMT
Task Type Bugs
Category Music playback
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


I see two problems.

1. Repeat shuffle is repeat. It never shuffles anything.
2. Repeat shuffle would be redundant even if it did. We already have shuffle mode and repeat mode, like every other audio player, so mimicing Repeat Shuffle is obvious. Since it is unecessary and would cause confusion (Repeat Shuffle ON but Shuffle OFF equals what?), I would rather see Repeat Shuffle removed, not fixed.

I have only witnessed this bug on a H340.
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Wednesday, 27 December 2006, 01:51 GMT
Reason for closing:  Fixed
Comment by Jonas Häggqvist (rasher) - Sunday, 05 November 2006, 21:48 GMT
1. Certainly sounds like a bug. Haven't noticed this.

2. Since the shuffle only changes the order of songs once, Repeat Shuffle is not redundant since it lets you listen to your songs without having the same songs come in the same order. Consider the following examples:

- Repeat All, Shuffle on:
(list is shuffled)-C-A-B-C-A-B

- Repeat Shuffle, shuffle on:
(list is shuffled)-C-A-B-(list is shuffled)-A-C-B

- Repeat Shuffle, Shuffle off:
A-B-C-(list is shuffled)-C-B-A

Once you realise how the shuffle modes work, all of them can be useful.
Comment by Dan (Skyly) - Monday, 06 November 2006, 17:15 GMT
Rockbox is the only system I know that doesn't reshuffle automatically.
So the one-shuffle-only problem could be solved by changing that, which would also remove the need for the Repeat Shuffle option. While that is what I would prefer personally, I can't easily argue against having any extra option. Some people might find it valuable to be able to play their tracks in order once through before shuffling, or might prefer having their as-yet-unordered playlist repeat in the same unknown order each time.

So assuming both kinds of shuffle remain, I state two things:

1) Repeat Shuffle is only bugged when Shuffle is off. This is when it functions exactly the same as Repeat All, not only failing to ever shuffle, but also reverting to the original playlist order.

Repeat Shuffle + Shuffle on does as expected, which is the same thing as Repeat All + Shuffle on other media players. Shuffles immediately and following every play through.

Rockbox needs to either function as Jonas suggested for Repeat Shuffle + Shuffle Off, or remove the Repeat Shuffle option when Shuffle is off, since currently it is pointless.

2) Since Rockbox's Shuffle is unlike other media players, could it perhaps be presented so that it is clearer about when it is not reshuffling?

Rockbox enthusiasts understand the different modes, but new users have to work out the difference between the two shuffles. This would take a while of tinkering before they figure things out, but I think it is more likely that they just assume shuffle works the same as every other player, and never really notice what's going on.

I would suggest something like this:
Repeat toggles between Off->On->All
Shuffle toggles between Off->On ...while Repeat All is not selected.
Shuffle toggles between Off->Once only->Reshuffle ...while Repeat All is selected.

If both shuffle modes remain, I think the above is more elegant than having different shuffles operable at once, and clearer to the user about what the different modes mean.