Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes 1
  • Private
Attached to Project: Rockbox
Opened by blue_lizard - 2006-11-09
Last edited by Jonathan Gordon - 2007-08-05

FS#6310 - Progressbar while deleting folders.

This patch introduces an progressbar while the device deletes folders/files.
It should work on all devices that have HAVE_LCD_BITMAP.
If a wps with an grafical progressbar is used it will use it for this too if not a simple bar will be presented.
Of course an % counter is also present.
Devices that don’t have HAVE_LCD_BITMAP the normal delete routine will be used.
Has been tested on H300 hardware and sim.

Closed by  Jonathan Gordon
2007-08-05 10:25
Reason for closing:  Out of Date
Dan Everton commented on 2006-11-10 09:22

Seems like a lot of code for not much extra value. From a quick skim, it seems you count the number of files, then do the deletion. Doesn’t this make deleting twice as slow? Maybe an “infinite” progress bar might be a better choice if you really want some sort of indication of progress.

blue_lizard commented on 2006-11-12 00:45

Yes from a quick skim it might seem so.
I am not only counting the files i am also counting the bytes. So the progress bar is quite accurate and is the exact opposite of your proposed “infinite” progress bar. I didn’t want some sort of response, i want an accurate response one can rely on.
Is seems that on your systems something is totally wrong because deleting files on your fat file systems is so fast or traversing directories is way too slow. I made following measurements on my h340 (hd spin up times are included).
Deleting 3565 M bytes (571 files)
Without patch: ~75 Seconds
With patch : ~80 Seconds
The relation may change if one deletes fewer files.
Furthermore the code is of course bigger than before but 1/3 of code is the original routine that is used in systems that don’t have an graphical display. This code is not compiled in if it is not used and vice versa.

Dominik Riebeling commented on 2006-11-12 08:11

for your measurements, had you dircache enabled? I wouldn’t be surprised if this would be way slower with dircache disabled.

Robert Kukla commented on 2006-11-12 15:02

I like the progress indicator very much - an activity indicator wouldn’t give much more information than the hard disk activity light already gives.

Could it possibly be extended and used for “paste” as well which is another time consuming operation.

BTW: there are two missing prototypes in the code:

onplay.c: In function `remove_dir_execute’:
onplay.c:473: warning: implicit declaration of function `gui_bitmap_scrollbar_dr
aw’ onplay.c:479: warning: implicit declaration of function `gui_scrollbar_draw’

blue_lizard commented on 2006-11-14 22:07

@bluebrother
as far as i remember dircache was disabled because it is default in an new installation. Because i am not absolutely sure anymore i made some new test.

original without dircache: ~78s
original with dircache: ~75s
patched without dircache: ~86s
patched with dircache: ~82s

again with 3565 M bytes (571 files)

@roolku
i am already working on the progress bar for copying files

The problem with the two unresolved symbols can be circumvented if i would include scrollbar.h.
Unfortunately this is not possible at the moment because the symbols HORIZONTAL and VERTICAL are defined in recorder/widgets.h and in gui/scrollbar.h
The original onplay.c already includes plugin.h which includes widgets.h. and therefore can’t include scrollbar.h at the same time because that would redefine the symbols.
This is a problem the core developers have to solve. At the moment we have to live with that.

blue_lizard commented on 2006-11-20 22:30

Sorry i haven’t had much time.
For the people that still are interested, if any:
Progress bar while deleting files and progress bar while copying files.

Robert Kukla commented on 2006-11-20 23:03

Looks very good!

Could I suggest one improvement? Could you display the directory that is being deleted/copied? Not every individual item, just the entry that was selected in the file browser. Sometimes during a long delete I panic that I might have selected the wrong directory and such a display would re-assure me and prevent me from frantically trying to abort the process. :)

Peter D'Hoye commented on 2006-12-01 20:51

Some remarks:

1. As far as I can see this code doesn’t use dircache to build the summary so that’s why dircache doesn’t seem to make much difference in the above timings.
2. This seems a BIG overkill to me. I was thinking of displaying the dir being deleted as info, not something big as this. FYI, I had no choice but to move the file/dir property to a plugin because of the wasted binary size. If file operations could also move to a plugin this would already be much better.

Oleg G commented on 2007-02-24 18:38

Patch broken against newest SVN. Seems like the big menu changes screwed it up.

Peter D'Hoye commented on 2007-06-07 09:04

My vote to this task is actually a negative oneā€¦. I’ll never click on links again unless I understand it ;)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing