FS#6336 - Patch to let Sansa e200 normal to be built.

Attached to Project: Rockbox
Opened by Gnelik (Gnelik) - Wednesday, 15 November 2006, 18:45 GMT
Task Type Patches
Category Operating System/Drivers
Status Closed
Assigned To No-one
Operating System PortalPlayer-based
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Patch to let Sansa e200 normal firmware to be built.
This task depends upon

Closed by  Steve Bavin (pondlife)
Wednesday, 22 November 2006, 10:24 GMT
Reason for closing:  Accepted
Additional comments about closing:  \"This is now in CVS\"

I\'ll close it then!
Comment by Daniel Ankers (dan_a) - Wednesday, 15 November 2006, 22:06 GMT
There are a couple of places where you have checked for all of the CONFIG_CPU==PP50XX. You can replace these with defined (CPU_PP). You seemed to have missed a few things out, though - it did not compile cleanly for me.

Based on your patch, I've made a new one. It compiles with one warning (from the ATA driver,) but does not boot.
Comment by Daniel Ankers (dan_a) - Friday, 17 November 2006, 09:41 GMT
Oops - the patch was against an old CVS. Updated.
Comment by Daniel Ankers (dan_a) - Saturday, 18 November 2006, 18:40 GMT
The MI4 code overwrites some of the generated binary. This new version does a bit better at booting, but still doesn't get as far as showing the Rockbox logo.
Comment by Daniel Ankers (dan_a) - Sunday, 19 November 2006, 18:30 GMT
A much cleaner version of the above.
This corrects the codec definition, and drops the (incomplete) NAND driver.
This version compiles without any warnings.
Comment by Daniel Ankers (dan_a) - Sunday, 19 November 2006, 22:09 GMT
This corrects problems we have found with the LCD driver.
There is a problem with the interrupt vectors not being copied properly which causes the boot to fail. This patch does nothing to fix that.
Comment by Daniel Ankers (dan_a) - Tuesday, 21 November 2006, 18:55 GMT
This fixes the problem. It also includes the NAND driver again (with write support this time.) It is known to be faulty on 6/8Gb Sansas - I would not suggest testing it on one of those models.
Comment by Daniel Ankers (dan_a) - Wednesday, 22 November 2006, 01:38 GMT
This is now in CVS