Rockbox

  • Status Closed
  • Percent Complete
    0%
  • Task Type Patches
  • Category Drivers
  • Assigned To
    Jonas Häggqvist
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Jonas Häggqvist - 2006-11-20
Last edited by Jonathan Gordon - 2007-07-03

FS#6358 - Check for illegal chars on filename creation

This patch adds an additional check to fat_checkname to disallow the following characters: " * / : < > ?
| as per the FAT spec (p 29 of FAT32spec103.pdf). I have tested it to work and fix a problem (previously you could create filenames with (at least) some of these characters. This patch manages to fix that.

(application/octet-stream)    fatcheck.diff (1.3 KiB)
Closed by  Jonathan Gordon
2007-07-03 09:53
Reason for closing:  Accepted
Jonas Häggqvist commented on 2006-11-20 00:27

Updated to use strchr() rather than manually looping. Checked on H120 target.

(application/octet-stream)    fatcheck_2.diff (1.2 KiB)
Magnus Holmgren commented on 2007-04-03 17:13

Some further updates, to recude size a little, and check some more things.
Also reduces the size of the char2dos function (~170 bytes on ColdFire).
Checked on H120 too.

(application/octet-stream)    fat_check_3.diff (1.8 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing