FS#6358 : Check for illegal chars on filename creation

FS#6358 - Check for illegal chars on filename creation

Attached to Project: Rockbox
Opened by Jonas Häggqvist (rasher) - Monday, 20 November 2006, 00:00 GMT
Last edited by Jonathan Gordon (jdgordon) - Tuesday, 03 July 2007, 09:53 GMT

Task Type	Patches
Category	Drivers
Status	Closed
Assigned To	Jonas Häggqvist (rasher)
Operating System	All players
Severity	Low
Priority	Normal
Reported Version
Due in Version	Undecided
Due Date	Undecided
Percent Complete
Votes	0
Private	No

Details

This patch adds an additional check to fat_checkname to disallow the following characters: " * / : < > ? \\ | as per the FAT spec (p 29 of FAT32spec103.pdf). I have tested it to work and fix a problem (previously you could create filenames with (at least) some of these characters. This patch manages to fix that.

fatcheck.diff (1.3 KiB)

This task depends upon

Closed by Jonathan Gordon (jdgordon)
Tuesday, 03 July 2007, 09:53 GMT
Reason for closing: Accepted

Comments (2)
Related Tasks (1/0)

Comment by Jonas Häggqvist (rasher) - Monday, 20 November 2006, 00:27 GMT

Updated to use strchr() rather than manually looping. Checked on H120 target.

fatcheck_2.diff (1.2 KiB)

Comment by Magnus Holmgren (learman) - Tuesday, 03 April 2007, 17:13 GMT

Some further updates, to recude size a little, and check some more things.
Also reduces the size of the char2dos function (~170 bytes on ColdFire).
Checked on H120 too.

fat_check_3.diff (1.8 KiB)

	Tasks related to this task (1)
	~~FS#5659 - renaming can generate filenames that are inaccessible from windo~~

Duplicate tasks of this task (0)

Rockbox

FS#6358 - Check for illegal chars on filename creation

Details

Loading...