• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Yotto - 2006-11-23

FS#6378 - WPS lockup with id3 tag > 128 characters

When a dynamically created line (Say, %ia) has over 128 characters, the WPS screen freezes, playback stops, and you must do a hard reset. This happens consistently on my iPod video 30gig, but I assume it would happen on other models.
I could (and do) just edit the tags, but as this happens on some podcasts, it is a constant issue.

Closed by  learman
2006-12-17 15:52
Reason for closing:  Fixed
petur commented on 2006-12-11 22:16

Can you build your own version? And try the attached patch?

petur commented on 2006-12-11 22:23

hmmm I’m unable to reproduce using a very long artist name using iCatcher. It does use %ia….

Yotto commented on 2006-12-11 22:44

Sorry, I left out one very important part. %s has to be on the line as well to make it scroll. I just tested it again and it locked up.

I sadly do not know how to compile.

petur commented on 2006-12-12 21:35

I tried with iCatcher and it doesn’t want to crash. What wps do you use?

petur commented on 2006-12-12 22:23

Sorry, that attached patch won’t change a thing

Hm, I just run into this myself and trying to reproduce it I noticed that it doesn’t crash if the tags are in unicode (as saved by winamp). The same track and only the tag changed to ISO 8859-1 (in tag&rename) crashes rockbox. I will try and do some more investigation with logf later tonight, but maybe this fact gives someone an idea on what goes wrong here - in theory the actual id3→title string should be the same after unicode_munge() in id3.c…


Available keyboard shortcuts


Task Details

Task Editing