Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Music playback
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by sdoyon - 2006-11-28
Last edited by jdgordon - 2007-08-05

FS#6388 - Pitch as a setting

Is there any reason why the pitch value isn't saved along with other
settings?

I would like it to persist across reboots, and possibly to be able to set
it through a config file.

Here's a patch, seems to work for me but it would need review.

   pitch.diff (3.3 KiB)
Closed by  jdgordon
2007-08-05 13:26
Reason for closing:  Out of Date
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

patch very out of date.. if someone really wants this a new patch is needed

Project Manager
linusnielsen commented on 2006-11-28 08:45

The pitch is not saved because it is considered temporary, and not something people in general would want to have persistent. That is because the original idea was to use the pitch for DJ mixing. However, if there is a general need for it to be saved, we could of course apply this patch.

sdoyon commented on 2006-11-28 14:40

Well my use for pitch is to play audio books faster. Also useful for
podcasts. Long time audio book readers develop this ability to understand
fast speech, up to maybe 2times when concentrating and in quiet
surroundings. Reading outloud is relatively slow :-). Blind readers have
gotten used to speeding it up because we've had those specialized
cassette players with adjustable speed available for over 25years. And
when you're actually working with an audio book (as opposed to just
relaxing) then there's a productivity angle.

Later specialized cassette player models (since maybe 15years) also offer
a function to compensate the pitch transpose that occurs when speeding up
playback. Nowadays the digital Daisy players do that in software. That's
like sox's pitch effect I believe: speed up playback but keep the pitch
the same. (Some voicemail services offer that too…) That's a capability
I would dearly like to see added to RB, because high-pitched speech is
less intelligible and somewhat annoying, and I intend to look into
integrating some code for that some day, but that's another story.

Anyway the point was that it's much nicer to have the pitch as a
persistent setting, so that when you turn your player back on and resume
playing your audio book, it continues at the speed you had it when you
shut it off.

nls commented on 2006-11-28 21:00

Here's a (rather heated) discussion on the matter (speed/pitch thing)  FS#5668 

darkkone commented on 2006-11-30 03:05

Here's my opinion on the matter:

Pitch, adjusted from the Sound Settings Menu, should be treated as permanent. Pitch from the pitch quickscreen should be treated as temporary.

If you only want to change it once, ever, going to a static screen for it isn't so much a cost, whereas that way it doesn't become permanent for those used to adjusting it temporarily anyway.

fml2 commented on 2006-12-03 19:49

Paul, I like your idea very much! If it should be done then this way!

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing