Rockbox

The patch has been updated to include the drivers for the wake-up alarm (see wiki). Currently only the functionality of the Archos alarm mod is implemented, although the ds1339c offers more options and a second alarm.

The following two lines need to be uncommented in config-h120.h
#define CONFIG_RTC RTC_DS1339C
#define HAVE_ALARM_MOD

Remember to update the software before you install the mod - otherwise you will get caught out with the play button constantly pressed (the patched rockbox will disable it at startup).

   rtc_with_alarm.patch (20.3 KiB)

Very useful! H120 needs a RTC.
I have had a fight against the compiler (and he won… :( !!!).
I haven't a lot of free time, then I hope I'll find the patch in a next daily build, so that I'll go to the hardware.

Thanks,
Gianluca "Datman"

It worked a couple of builds ago, but fails to compile against the most recent CVS build (2007-01-02 15:48) when the config-h120.h lines are uncommented. Here are the error messages that it gives:

LD rockbox.elf
/home/user/rockbox-devel/build_h120/apps/alarm_menu.o: In function `alarm_screen':
alarm_menu.c:(.text+0x16): undefined reference to `rtc_get_alarm'
alarm_menu.c:(.text+0x3c): undefined reference to `rtc_enable_alarm'
alarm_menu.c:(.text+0x1f2): undefined reference to `rtc_init'
alarm_menu.c:(.text+0x200): undefined reference to `rtc_set_alarm'
alarm_menu.c:(.text+0x20a): undefined reference to `rtc_enable_alarm'
alarm_menu.c:(.text+0x2d8): undefined reference to `rtc_enable_alarm'
/home/user/rockbox-devel/build_h120/apps/main.o: In function `init':
main.c:(.text+0x20e): undefined reference to `rtc_init'
/home/user/rockbox-devel/build_h120/apps/tree.o: In function `start_resume':
tree.c:(.text+0x5f2): undefined reference to `rtc_check_alarm_started'
tree.c:(.text+0x600): undefined reference to `rtc_enable_alarm'
/home/user/rockbox-devel/build_h120/librockbox.a(powermgmt.o): In function `power_thread_rtc_process':
powermgmt.c:(.text+0x536): undefined reference to `rtc_check_alarm_flag'
powermgmt.c:(.text+0x542): undefined reference to `rtc_enable_alarm'
/home/user/rockbox-devel/build_h120/librockbox.a(timefuncs.o): In function `get_time':
timefuncs.c:(.text+0xb2): undefined reference to `rtc_read_datetime'
/home/user/rockbox-devel/build_h120/librockbox.a(timefuncs.o): In function `set_time':
timefuncs.c:(.text+0x260): undefined reference to `rtc_write_datetime'
collect2: ld returned 1 exit status
make[1]: * [/home/user/rockbox-devel/build_h120/apps/rockbox.elf] Error 1
make: * [all] Error 2

The addition of the rtc driver for the gigabeat broke the patch. Now fixed.

   rtc_with_alarm.patch (20.4 KiB)

First attempt in adding auto detection for the MOD. It works as follows:

- during rtc_init() the global variable rtc_detected is set to true if the RTC mod is detected
- if CONFIG_RTC == RTC_DS1399_DS3231 an rtc_detected check is done before performing RTC related task such as

+ create entries for "set date/time" and "set alarm" menus
+ display time in status bar
+ evaluate WPS %C tags
+ filename generation
+ scrobbler entries
+ FAT time generation
+ time functions

I went for low impact on existing code. Some bits (i.e. fat.c could do with some re-structuring.)

Please test (especially on units without the MOD) and let me know of any problems.

(The patch conflicts with the system_settings_menu change of the REP - you can find a build that has been adjusted here: http://roolku.pwp.blueyonder.co.uk/rockbox_rep_rtc_r12186.zip )

   rtc_with_alarm+autodetect.pat... (30.3 KiB)

Sorry I got the link wrong. The version with MOD auto detection is: http://roolku.pwp.blueyonder.co.uk/rockbox_rep_rtc_r12213.zip

I have reviewed the patch and here are some comments:

1) You don't respect the indentation. Please do.

2) I think the i2c-bitbang.c file should be in the target/coldfire/iriver tree.

3) I think it would be nicer if rtc_detected would be a function, but it's not a big deal.

Thank you very much for checking it out.

1) I have left the original indentation in place intentionally so the diff would only show the real changes and not the added white space, but I will adjust it

2) I will move it. Shall I place eeprom_24cxx.c there as well?

3) I had it like that originally (as this is what the radio detection does), but could not see a good reason for justifying the additional function call overhead to check a boolean var.

Hopefully I will get it done today.

1) Well, what I meant was that your added code was not aligned with the existing code. Example:

#ifdef CONFIG_RTC

      case 'c':  /* Real Time Clock display */
           *flags |= WPS_REFRESH_DYNAMIC;

+#if CONFIG_RTC == RTC_DS1339_DS3231
+ if(!rtc_detected)
+ return NULL;
+ else
+#endif

2) Not sure. If it is fairly generic, I think it could stay in the firmware/drivers tree.

3) Don't bother.

Okay I have:

- fixed indentation
- moved the i2c-bitbang.c file to target/coldfire/iriver
- adapted the menu to JdGordons' new menu system (I think it handles dynamic menus a lot less elegantly than previously though)
- made the #include rtc.h conditional on CONFIG_RTC to be consistent with radio.h
- made sure the h120 sim works

I have compiled it for h120, h120 sim and gigabeat and run it on a modified and an unmodified h120.

   rtc_with_alarm+autodetect2.pa... (31.2 KiB)

Synced to current svn.

   rtc_with_alarm+autodetect2.pa... (30 KiB)

Updated to current svn, a few fixes and some restructuring in the logic of fat.c. Please test (especially with non-rtc units).

   5rtc_with_alarm+autodetect.pa... (30.3 KiB)

- unconditionally disable square wave output on every boot - prevents problems with ALARM MOD on first start up for DS1339; DS3231 should be unaffected
- not tested under 'real' conditions

   6rtc_with_alarm+autodetect.pa... (30.2 KiB)

This is the RC which I will commit after a little more testing. I tidied up the split between the i2c for H100 and h300 and some other minor changes.

   7rtc_with_alarm+autodetect.pa... (32.2 KiB)