Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Infrastructure → Build environment
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by lenny - 2007-01-04
Last edited by barrywardell - 2007-08-13

FS#6499 - fix rockboxdev.sh make/gmake detection in Mac OS X/Darwin

A commit on 22 Nov 09:07 added detection for gmake so it can be used if available.

I assume on standard *nix distros the command “which” should return nothing if the program is not found. However, in mac os x (darwin) “which” returns with an error message when a program is not found.

Example:
$ which gmake
no gmake in /bin /sbin /usr/bin /usr/sbin

This creates problems for this if statement:

if [ -n “`which gmake`” ]; then 

  make="gmake"

else

I have added a subsequent if statement which seems to fix the problem.

Let me know how I did! (first patch)

(application/octet-stream)    rockboxdev_gmake_in_mac.patch (0.5 KiB)
Closed by  barrywardell
2007-08-13 00:10
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Thanks.

lenny commented on 2007-01-05 08:35

I suspect this behavior (the presence of an error message from "which") is not Darwin specific. Perhaps a BSD thing?

mlind commented on 2007-01-09 21:55

Works great for me!

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing