Rockbox

Tasklist

FS#6539 - e200 Plugin Work

Attached to Project: Rockbox
Opened by Tom Ross (midgey34) - Monday, 15 January 2007, 02:40 GMT
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Operating System Sansa e200
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

These patches add Jewels, Spacerocks, and Wormlet to the e200. These patches also include the necessary manual changes. The zip file includes the images that should be placed in /manual/plugins/images . The plugins have been tested and work on the simulator, however, the manual changes have not since I can no longer build the manual. As an added bonus, the keymappings have been included for the X5 for wormlet.
This task depends upon

Closed by  Barry Wardell (barrywardell)
Monday, 15 January 2007, 21:04 GMT
Reason for closing:  Accepted
Additional comments about closing:  Committed to CVS.
Comment by Tom Ross (midgey34) - Monday, 15 January 2007, 03:37 GMT
Turns out those manual changes were bad. Here are the updated patches (these work). PS: the top part of the wormlet manual looks out of date to me.
Comment by Tom Ross (midgey34) - Monday, 15 January 2007, 05:33 GMT
Here's rockboy for the e200 including the manual changes. Attached is the patch and the image that should go in /manual/plugins/images/ . Enjoy.
Comment by Barry Wardell (barrywardell) - Monday, 15 January 2007, 10:50 GMT
I have just tested these on my e200.

Jewels works well. It is missing help text though (help text is also missing for the H10).

Spacerocks works well, although it looks like the drawing of lives left wraps around to the top of the screen. You can see this in the screenshot too.

Wormlet works well.

I haven't tested RockBoy yet.
Comment by Tom Ross (midgey34) - Monday, 15 January 2007, 15:47 GMT
Updated version of jewels that adds the help text for e200 and h10 and gives a warning if the text is not defined. Also contains a new version of rockboy to fix a small bug. I'll look into spacerocks to see what I can do.
Comment by Tom Ross (midgey34) - Monday, 15 January 2007, 17:00 GMT
Alright, here's a fixed version of spacerocks. The bug Barry mentioned had nothing to do with my original patch but rather the changes made in 11881 and effected all screens larger than ondio. Also I've changed the C++ style comments to C.
Comment by Barry Wardell (barrywardell) - Monday, 15 January 2007, 17:58 GMT
They all work great now. The rockboy keymaps might be a bit awkward to use but I can't think of any better one, so I think they're OK.
Comment by Tom Ross (midgey34) - Monday, 15 January 2007, 19:15 GMT
This fixes a small mistake that broke the h300 wormlet. In addition, I've added sudoku and made the necessary manual changes.
Comment by Barry Wardell (barrywardell) - Monday, 15 January 2007, 20:49 GMT
I have committed this to CVS.
I left out the removing ship rotation in spacerocks ship initialization as i don't see the purpose of removing it. Please feel free to explain your reasoning and I will commit it.
Also made a couple of minor additional adjustments to the Jewels and Wormlet manual sections.
Changed Sudoku keymap to make use of the scroll wheel for changing numbers.
I agree that the start of the Wormlet manual section is a bit odd, but that's probably the subject of another bug report.

Loading...